Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the initial conditions inside of StaircaseDNS #48

Closed
jbisits opened this issue Nov 10, 2024 · 1 comment · Fixed by #50
Closed

Set the initial conditions inside of StaircaseDNS #48

jbisits opened this issue Nov 10, 2024 · 1 comment · Fixed by #50
Labels
enhancement New feature or request Project 3 Code development relating to the third project in my PhD

Comments

@jbisits
Copy link
Owner

jbisits commented Nov 10, 2024

For the method where model_setup is passed it makes sense to do this because the initial conditions are needed to setup either the boundary conditions or the background state.

@jbisits jbisits added the enhancement New feature or request label Nov 10, 2024
@jbisits
Copy link
Owner Author

jbisits commented Nov 10, 2024

These two

"Build the model from `model_setup` then return a `StaircaseDNS`, mainly used to build
the `model` with [reentrant_boundary_conditions](@ref) `boundary_conditions` from `initial_conditions`."
function StaircaseDNS(model_setup::NamedTuple, initial_conditions, initial_noise)
boundary_conditions = reentrant_boundary_conditions(initial_conditions)
architecture, diffusivities, domain_extent, resolution, eos = model_setup
model = DNSModel(architecture, domain_extent, resolution, diffusivities, eos; boundary_conditions)
return StaircaseDNS(model, initial_conditions, initial_noise)
end
"`StaircaseDNS` that is `Periodic` in z direction and evoloves an anomaly around a
background state."
function StaircaseDNS(model_setup::NamedTuple, initial_conditions::PeriodoicSingleInterfaceICs, initial_noise)
architecture, diffusivities, domain_extent, resolution, eos = model_setup
z_topology = Periodic
τ = diffusivities.κ.S / diffusivities.κ.T
background_fields = S_and_T_background_fields(initial_conditions, domain_extent.Lz, τ)
model = DNSModel(architecture, domain_extent, resolution, diffusivities, eos;
z_topology, background_fields)
return StaircaseDNS(model, initial_conditions, initial_noise)
end

@jbisits jbisits added the Project 3 Code development relating to the third project in my PhD label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Project 3 Code development relating to the third project in my PhD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant