Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Add test coverage to GatedSAE and JumpReLU implementations #323

Closed
1 task done
chanind opened this issue Oct 7, 2024 · 0 comments · Fixed by #328
Closed
1 task done

[Proposal] Add test coverage to GatedSAE and JumpReLU implementations #323

chanind opened this issue Oct 7, 2024 · 0 comments · Fixed by #328

Comments

@chanind
Copy link
Collaborator

chanind commented Oct 7, 2024

Proposal

Currently, the GatedSAE and JumpReLU implementations are missing test coverage, as noted in https://github.com/jbloomAus/SAELens/blob/main/sae_lens/sae.py#L425, and shown by #322. We should add tests to these so we can be confident they are implemented correctly and avoid regressions moving foward.

Checklist

  • I have checked that there is no similar issue in the repo (required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Test JumpReLU/Gated SAE and fix sae forward with error term jbloomAus/SAELens
1 participant
@chanind