Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walker:macroexpand-all doesn't handle declarations in symbol-macrolet correctly #42

Open
Gleefre opened this issue Nov 1, 2024 · 0 comments
Assignees
Labels

Comments

@Gleefre
Copy link

Gleefre commented Nov 1, 2024

walker:macroexpand-all signals incorrect warnings when processing symbol-macrolet with declarations:

(require :walker)
(walker:macroexpand-all '(symbol-macrolet () (declare)))
; >> ;;; Warning: Encountered declare (DECLARE) in a place where a declare was not expected.
; => (SYMBOL-MACROLET ()
;      (DECLARE))

This warning is incorrectly signaled.

CLHS (symbol-macrolet) allows declarations in symbol-macrolet:

Syntax: symbol-macrolet ((symbol expansion)) declaration form*

Tested on MKCL 1.1.11.206 (current head):

(lisp-implementation-version)  ; => "1.1.11.206-b414811"

This also affects ECL, see https://gitlab.com/embeddable-common-lisp/ecl/-/issues/764.

@jcbeaudoin jcbeaudoin self-assigned this Nov 1, 2024
@jcbeaudoin jcbeaudoin added the bug label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants