Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument must implement interface Mutex, Repository given #13

Closed
japsen opened this issue Apr 20, 2017 · 6 comments
Closed

Argument must implement interface Mutex, Repository given #13

japsen opened this issue Apr 20, 2017 · 6 comments

Comments

@japsen
Copy link

japsen commented Apr 20, 2017

[Symfony\Component\Debug\Exception\FatalThrowableError]
  Type error: Argument 1 passed to Illuminate\Console\Scheduling\Event::__con
  struct() must implement interface Illuminate\Console\Scheduling\Mutex, inst
  ance of Illuminate\Cache\Repository given, called in /var/www/vendor/jdavid
  bakr/multi-server-event/src/Scheduling/Event.php on line 45

I get this when executing "php laravel" on console. running laravel framework 5.4.19, jdavidbakr/multi-server-event version 2.0.1

Minor: There is an unmatched bracket in the example Kernel.php defineConsoleSchedule code on https://github.com/jdavidbakr/MultiServerEvent

@james-coder
Copy link

james-coder commented Apr 25, 2017

jdavidbakr/multi-server-event still works with laravel/framework 5.4.16.

It looks like this broke when laravel framework went to 5.4.17.
laravel/framework@v5.4.16...v5.4.17
(See the many changes of Illuminate\Contracts\Cache\Repository to Illuminate\Console\Scheduling\Mutex there.)

Part of 5.4.16 was this breaking change: laravel/framework#18295

@jdavidbakr
Copy link
Owner

PR merged

@benswinburne
Copy link

Did you bump the composer version after this change? It doesn't appear so?

@jdavidbakr
Copy link
Owner

It should be in 1.0.9

@benswinburne
Copy link

Doesn't appear to to be in the 2.x release for > 5.4?

@jdavidbakr
Copy link
Owner

My bad, looks like I accidentally released in the 1.x branch instead of the 2.x branch. Should be there now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants