Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdlet checks on ".db" file's extension #17

Closed
kolmidad opened this issue Feb 10, 2023 · 3 comments
Closed

Cmdlet checks on ".db" file's extension #17

kolmidad opened this issue Feb 10, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request pending pending user feedback

Comments

@kolmidad
Copy link

Hi,

There's a check that runs at cmdlet starting on database file extension.
It seems to allow ".db" pattern only and won't run in any other case.
We use ".sqlite" extension for naming our Sqlite database files as it is allowed (also default in Sqlite DB Browser).
This is handy for us because we may use several DB engines on the same filesystem with no ambiguity.

Will you agree to modify these cmdlets in a more permisive way ?
Is there any strong reason not to ?

Thanks a lot by advance as doing this allows us to add your work in our team's tool box.

@jdhitsolutions jdhitsolutions added the enhancement New feature or request label Feb 10, 2023
@jdhitsolutions jdhitsolutions self-assigned this Feb 10, 2023
@jdhitsolutions
Copy link
Owner

This is a reasonable request. I can add a test for all the valid extensions. It looks like Export-MysqliteDB is the only command where this is an issue. Or is there some other command that is problematic?

@jdhitsolutions jdhitsolutions added the pending pending user feedback label Feb 10, 2023
@kolmidad
Copy link
Author

yes indeed, it looks like other cmdlet accepts .sqlite extension
sorry for that I didn't checked far enough before asking
anyway I'm glad to read you'll extend the filename test
again thank you very much

@jdhitsolutions
Copy link
Owner

I've pushed v0.11.0 to the PowerShell Gallery with the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending pending user feedback
Projects
None yet
Development

No branches or pull requests

2 participants