Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# specific syntax highlighting #33

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Conversation

huipvandenende
Copy link
Contributor

I love this theme but felt that it could be improved a bit for C# use. I changed some colors so it's easier to for example differentiate fields from functions. I also added a C# code example.

Old:
exampleOld

New:
exampleNew

Copy link
Owner

@jdinhify jdinhify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huipvandenende for this PR, and apologies for the late review.

Just a comment to see whether we should use dark purple instead for C# this. Please try and see which one you prefer

themes/gruvbox-dark-hard.json Outdated Show resolved Hide resolved
@jdinhify
Copy link
Owner

Also please add yourself to the contributors section in package.json & README.md 🙏

@huipvandenende
Copy link
Contributor Author

I have updated the colors so "this" is consistent with the other purple elements. Thanks for pointing that out.

(Excuse the fat fingers)

Copy link
Owner

@jdinhify jdinhify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huipvandenende , I'll merge this & release soon

@jdinhify jdinhify merged commit aea4fde into jdinhify:master Apr 28, 2021
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
# [1.5.0](v1.4.0...v1.5.0) (2021-04-29)

### Features

* ✨  add C# specific syntax highlighting ([#33](#33)) ([aea4fde](aea4fde))
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
# [1.5.0](v1.4.0...v1.5.0) (2021-04-29)

### Features

* ✨  add C# specific syntax highlighting ([#33](#33)) ([aea4fde](aea4fde))
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
# [1.5.0](v1.4.0...v1.5.0) (2021-04-29)

### Features

* ✨  add C# specific syntax highlighting ([#33](#33)) ([aea4fde](aea4fde))
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
# [1.5.0](v1.4.0...v1.5.0) (2021-04-29)

### Features

* ✨  add C# specific syntax highlighting ([#33](#33)) ([aea4fde](aea4fde))
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
# [1.5.0](v1.4.0...v1.5.0) (2021-04-29)

### Features

* ✨  add C# specific syntax highlighting ([#33](#33)) ([aea4fde](aea4fde))
@jdinhify
Copy link
Owner

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants