Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Chrome extension page linked from the site is a 404 page #1772

Closed
ldexterldesign opened this issue Sep 12, 2023 · 15 comments · Fixed by #1782
Closed

The Chrome extension page linked from the site is a 404 page #1772

ldexterldesign opened this issue Sep 12, 2023 · 15 comments · Fixed by #1782
Labels

Comments

@ldexterldesign
Copy link

ldexterldesign commented Sep 12, 2023

👋

As title

Screenshot:
Screenshot 2023-09-12 at 18 43 48

Steps to reproduce issue

Go to Chrome extension page

Unexpected behaviour

Dead page

Expected behaviour

Live page

If you're reading and:

  • agree then please vote up (e.g. +1, like), or;
  • disagree then please vote down (e.g. -1, dislike) - I'd love to know why?

Hope this helps

Regards

@Nightfirecat
Copy link
Member

Per https://github.com/jdm-contrib/justdelete.me-chrome-extension, the Chrome extension is no longer maintained. I can't say I recall offhand why that is--whether there were technical changes which we don't have bandwidth to support, or for other reasons.

@ldexterldesign
Copy link
Author

Thanks for reply

Oh, that's a shame

I see last repo' commit was in 2018 - I'm only 5 years late to notice!

Regards

@tupaschoal
Copy link
Member

I think it was a combined lack of interest from the community and lack of time from us maintainers

@Nightfirecat Nightfirecat reopened this Sep 13, 2023
@Nightfirecat
Copy link
Member

I'm gonna re-open this issue, as we shouldn't be linking to a dead Chrome web store link on the site.

@Nightfirecat Nightfirecat changed the title As a user, when I go to Chrome extension page, I want it to work so I can reference reviews BUG The Chrome extension page linked from the site is a 404 page Sep 13, 2023
@fregante
Copy link
Contributor

fregante commented Sep 15, 2023

"This extension violates the Chrome Web Store policy"

This is likely because the extension wasn't updated in 5 years and the rules changed in the meanwhile (e.g. it became required to provide a privacy policy and describe the need for each permission)

Screenshot

Judging by the code, I can probably rewrite a modern version of it and publish it in an hour, if there's any interest in keeping an official link to it.

@ldexterldesign
Copy link
Author

ldexterldesign commented Sep 15, 2023

If the effort is minimal then seems a shame not to have browser parity 🤷 CC @fregante

@tupaschoal
Copy link
Member

Judging by the code, I can probably rewrite a modern version of it and publish it in an hour, if there's any interest in keeping an official link to it.

I'd happily take a PR to bring it to modern era

@fregante
Copy link
Contributor

More than a PR, I was thinking of a new extension/repo that I can maintain personally. I'm not particularly into rewriting projects and then hoping that they won't end up unmaintained again (happened several times before) 😅 especially because, like in this case, the web store requires direct access and changes.

@PyroSamurai
Copy link
Member

@fregante Shouldn't be an issue to do it your way, we'll just put your repo into the organization when it's ready.
You'll still have full ownership over the repo.

@fregante
Copy link
Contributor

I submitted a version to the CWS, I'll let you know when they approve it ☺️

The extension has "no permissions" and only runs javascript once a day. The update of the toolbar icon is handled by the browser itself, without custom listeners, via declarativeContent. The API is a bit limited but it serves its basic purpose.

I opted to point the user to JustDeleteMe.xyz/#current.site.com on click so that further instructions can be followed there. There's an issue with the filtering there though, because these two searches are empty:

while this works:

It'd be great to use the domains array on the website’s search as well in order to find them easily, not just by name.

@fregante
Copy link
Contributor

gif

@tupaschoal
Copy link
Member

@fregante Shouldn't be an issue to do it your way, we'll just put your repo into the organization when it's ready.
You'll still have full ownership over the repo.

Yes! I mentioned a PR because we could reuse the repo that already exists, but you could have one commit deleting everything and another adding your version of the extension

@fregante
Copy link
Contributor

The extension has been available on the store for 2 days, I didn't even notice 😅

Store: https://chrome.google.com/webstore/detail/just-delete-me/dlhckcablohllindinahbbpnfgblimoe
Source: https://github.com/fregante/jdm

No permissions required:

Screenshot

@ldexterldesign
Copy link
Author

@fregante 👏😘

@fregante
Copy link
Contributor

The Chrome extension page linked from the site is a 404 page

Still is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants