Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go backend can't install tools without 'v' prefix in git repo tags #2606

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix: go backend can't install tools without 'v' prefix in git repo tags #2606

merged 2 commits into from
Sep 23, 2024

Conversation

roele
Copy link
Contributor

@roele roele commented Sep 18, 2024 •
edited
Loading

@jdx The infamous v prefix topic again. While general go module convention is to use v prefix there are several modules around without. Since versions can not be easily queried (for example via curl HEAD request) one approach i can think of handling this is a simple retry.

Fixes #2593

jdx
jdx reviewed Sep 18, 2024
View reviewed changes
src/backend/go.rs Outdated Show resolved Hide resolved
jdx
jdx reviewed Sep 18, 2024
View reviewed changes
src/backend/go.rs Outdated Show resolved Hide resolved
jdx
jdx reviewed Sep 18, 2024
View reviewed changes
src/backend/go.rs Outdated Show resolved Hide resolved
@roele roele force-pushed the issues/2593 branch 2 times, most recently from 2ffd956 to d9f48eb Compare September 23, 2024 16:30
jdx
jdx reviewed Sep 23, 2024
View reviewed changes
src/backend/go.rs Outdated Show resolved Hide resolved
@jdx jdx enabled auto-merge (squash) September 23, 2024 20:04
@jdx jdx merged commit 78c2647 into jdx:main Sep 23, 2024
11 checks passed
@roele roele deleted the issues/2593 branch September 23, 2024 20:14
This was referenced Sep 23, 2024
Merged
Merged
@sgtsquiggs
Copy link

Consider reverting this PR:

❯ mise install go:golang.org/x/tools/cmd/stringer@v0.21.0
mise versions should not start with a 'v', please remove it
mise Run with --verbose or MISE_VERBOSE=1 for more information

This is a breaking change!

@jdx
Copy link
Owner

jdx commented Sep 24, 2024

the go backend is experimental so breaking changes should be expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdx jdx jdx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go backend can't install tools without "v" prefix in git repo tags
3 participants
@roele @sgtsquiggs @jdx