Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mise plugins cause zsh to load .bashrc environment variables #2632

Open
shaicoleman opened this issue Sep 24, 2024 · 0 comments
Open

mise plugins cause zsh to load .bashrc environment variables #2632

shaicoleman opened this issue Sep 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@shaicoleman
Copy link

shaicoleman commented Sep 24, 2024

Describe the bug
Starting Visual Studio code (speficially the Ruby LSP plugin) can cause environment variables to be changed.
Recording: https://github.com/user-attachments/assets/c012a53f-199d-48f2-8da2-a581ecbf7146

To Reproduce
zsh shell
In the .bashrc set an environment variable
Start VSCode and install Ruby LSP plugin.

Expected behavior

  • Loading envrionment variable in one process should not affect other shells.
  • zsh shouldn't load .bashrc

Workarounds

  • Uninstall all plugins
  • add [ -z "${__MISE_SCRIPT}" ] || exit in .bashrc

mise doctor output

version: 2024.9.7 linux-x64 (743b7a7 2024-09-23)
activated: yes
shims_on_path: no

build_info: 
  Target: x86_64-unknown-linux-gnu
  Features: DEFAULT, NATIVE_TLS, OPENSSL
  Built: Mon, 23 Sep 2024 21:09:00 +0000
  Rust Version: rustc 1.81.0 (eeb90cda1 2024-09-04)
  Profile: release

shell: 
  /bin/zsh
  zsh 5.9 (x86_64-ubuntu-linux-gnu)

dirs: 
  data: ~/.local/share/mise
  config: ~/.config/mise
  cache: ~/.cache/mise
  state: ~/.local/state/mise
  shims: ~/.local/share/mise/shims

config_files: 
  ~/.config/mise/config.toml

backends: 
  cargo
  core
  go
  npm
  pipx
  spm
  ubi
  vfox

plugins: 


toolset: 
  ruby@3.3.5      
  python@3.12.6   
  node@20.17.0    
  go@1.23.1       
  rust@1.81.0     
  crystal@1.13.3  

env_vars: 
  MISE_SHELL=zsh

settings: 
  activate_aggressive = false
  all_compile = false
  always_keep_download = false
  always_keep_install = false
  asdf = false
  asdf_compat = false
  cache_prune_age = "30d"
  cargo_binstall = true
  color = true
  disable_default_shorthands = false
  disable_hints = []
  disable_tools = []
  experimental = false
  go_default_packages_file = "~/.default-go-packages"
  go_download_mirror = "https://dl.google.com/go"
  go_repo = "https://github.com/golang/go"
  go_set_gopath = false
  go_set_goroot = true
  go_skip_checksum = false
  http_timeout = 30
  jobs = 4
  legacy_version_file = true
  legacy_version_file_disable_tools = []
  libgit2 = true
  node_compile = false
  not_found_auto_install = true
  paranoid = false
  pipx_uvx = false
  plugin_autoupdate_last_check_duration = "7d"
  python_compile = true
  python_default_packages_file = "~/.default-python-packages"
  python_pyenv_repo = "https://github.com/pyenv/pyenv.git"
  raw = false
  trusted_config_paths = []
  quiet = false
  use_versions_host = true
  verbose = false
  vfox = false
  yes = false
  ci = false
  debug = false
  trace = false
  log_level = "info"
  python_venv_auto_create = false

  [ruby]
  default_packages_file = "~/.default-gems"
  ruby_build_repo = "https://github.com/rbenv/ruby-build.git"
  ruby_install = false
  ruby_install_repo = "https://github.com/postmodern/ruby-install.git"

  [status]
  missing_tools = "if_other_versions_installed"
  show_env = false
  show_tools = false

No warnings found
No problems found

Output of extrace

        104391 mise activate zsh
        104405 mise hook-not-found -s zsh -- asdf
          104418 /usr/bin/env bash /home/shai/.local/share/mise/plugins/crystal/bin/list-bin-paths
          104418 bash /home/shai/.local/share/mise/plugins/crystal/bin/list-bin-paths
          104419 /usr/bin/env bash /home/shai/.local/share/mise/plugins/crystal/bin/list-bin-paths
          104419 bash /home/shai/.local/share/mise/plugins/crystal/bin/list-bin-paths
    104421 /usr/bin/zsh -c '/home/shai/.local/bin/mise x -- ruby -W0 -rjson -e '\''STDERR.print("RUBY_LSP_ACTIVATION_SEPARATOR" + { env: ENV.to_h, yjit: !!defined?(RubyVM:: YJIT), version: RUBY_VERSION }.to_json + "RUBY_LSP_ACTIVATION_SEPARATOR")'\'''
    104421 /home/shai/.local/bin/mise x -- ruby -W0 -rjson -e 'STDERR.print("RUBY_LSP_ACTIVATION_SEPARATOR" + { env: ENV.to_h, yjit: !!defined?(RubyVM:: YJIT), version: RUBY_VERSION }.to_json + "RUBY_LSP_ACTIVATION_SEPARATOR")'
      104434 /usr/bin/bash -c '. /home/shai/.local/share/mise/plugins/rust/bin/exec-env'$'\n''export -p'$'\n'''
      104435 /usr/bin/bash -c '. /home/shai/.local/share/mise/plugins/crystal/bin/exec-env'$'\n''export -p'$'\n'''
    104421 ruby -W0 -rjson -e 'STDERR.print("RUBY_LSP_ACTIVATION_SEPARATOR" + { env: ENV.to_h, yjit: !!defined?(RubyVM:: YJIT), version: RUBY_VERSION }.to_json + "RUBY_LSP_ACTIVATION_SEPARATOR")'
@shaicoleman shaicoleman added the bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant