Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports OGP meta tag contents #82

Merged
merged 3 commits into from
Apr 23, 2017
Merged

Supports OGP meta tag contents #82

merged 3 commits into from
Apr 23, 2017

Conversation

sue445
Copy link
Contributor

@sue445 sue445 commented Apr 16, 2017

Overview

Supports OGP meta tag contents (e.g. <meta property="og:title" >)

Details

I want to share URL of slide generated with reveal-ck to twitter or facebook, but content is very cheep 😣

This PR supports arbitrary embed meta tag.

Example

Before

Twitter

before-tw

Facebook

before-fb

After

https://sue445.github.io/reveal-ck-example/#/

config.yml

meta_properties:
  og:type: "website"
  og:title: "Example slide"
  og:description: "Example slide"
  og:url: "https://sue445.github.io/reveal-ck-example/#/"
  og:image: "https://sue445.github.io/reveal-ck-example/images/github_unicorn.png"

meta_names:
  twitter:card: "summary"
  twitter:site: "@sue445"
  twitter:creator: "@sue445"
  twitter:title: "Example slide"
  twitter:description: "Example slide"
  twitter:image: "https://sue445.github.io/reveal-ck-example/images/github_unicorn.png"

Twitter

after-tw

Facebook

after-fb

sue445 added 3 commits April 16, 2017 22:11
@sue445
Supports meta contents
30d69bc
@sue445
Fix rubocop version
43609bb 
When use latest rubocop, violation occurs in unchanged code
https://travis-ci.org/jedcn/reveal-ck/jobs/222556617
@sue445
Resolved rubocop offense: Method has too many lines. [13/10]
fb848f7 
```
Offenses:

lib/reveal-ck/config.rb:23:5: C: Method has too many lines. [13/10]
    def core_defaults ...
    ^^^^^^^^^^^^^^^^^
```
@jedcn
Copy link
Owner

jedcn commented Apr 20, 2017

Hey there @sue445! Thanks for the PR!

I think you're the first person to write their own .feature. I appreciate it!

I've been on vacation for the past few days-- I'm back now and will take a closer look in the next day. Presuming all looks good I'll merge and then publish a new version of the gem.

I'll update this PR when there's more info. Thanks again!

@jedcn jedcn mentioned this pull request Apr 23, 2017
Merged
@jedcn jedcn merged commit fb848f7 into jedcn:master Apr 23, 2017
@jedcn
Copy link
Owner

jedcn commented Apr 23, 2017

Your changes are now available as version 3.6.0 of reveal-ck: https://rubygems.org/gems/reveal-ck/versions/3.6.0

@sue445 sue445 deleted the meta_contents branch April 23, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sue445 @jedcn