Supporting meta names and properties #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When use latest rubocop, violation occurs in unchanged code https://travis-ci.org/jedcn/reveal-ck/jobs/222556617
```
Offenses:
lib/reveal-ck/config.rb:23:5: C: Method has too many lines. [13/10]
def core_defaults ...
^^^^^^^^^^^^^^^^^
```
General ideas: * Allow some well-known files to not be snake_case * Use %i or %I for an array of symbols. * %w-literals should be delimited by [ and ] * Use %r around regular expression. * Start using ActiveSupport's String#strip_heredoc for more readable heredoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change builds off of #82.
In addition to the work there it:
CHANGELOG.md.<head prefix=""/>configurableHowever, the value of
<head prefix=""/>defaults to what's needed to support http://ogp.me/.Details
I'm opening this PR to provide transparency to @sue445.
The changes in #82 will be active once this comes in.
Thanks for your contribution!