Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about < and > #208

Closed
peaceshi opened this issue May 27, 2019 · 7 comments
Closed

about < and > #208

peaceshi opened this issue May 27, 2019 · 7 comments
Assignees
Labels
🐛 Bug Something isn't working Hard

Comments

@peaceshi
Copy link
Contributor

At last vsc knew what >> is !!
but,
image

I just make it more readable.
https://github.com/lhmouse/asteria/blob/bafd08ea05a36ae3967a761396875f7a3b602fe3/asteria/src/rocket/cow_hashmap.hpp#L30

@peaceshi
Copy link
Contributor Author

image
and what it is the .cpp?

@matter123 matter123 added the 🐛 Bug Something isn't working label May 27, 2019
@jeff-hykin
Copy link
Owner

The .cpp is def a bug, means we probably need to add an empty-string check somewhere.

@jeff-hykin
Copy link
Owner

Just to give a little context to this problem.
If we use a Pattern, we can do pretty complex stuff, but its limited to one line (so doesn't work for <>)
If we use a Range (start + end), we can do multiline, however once the 'start' has matched, it will not stop until it matches an 'end'.

Meaning if we did the easy solution of start < end > then a less-than comparison would mess everything up because it would be looking for an end that doesn't exist.

Thats not to say this isn't solvable, its just not going to be a straightforward solution.

@peaceshi
Copy link
Contributor Author

Meaning if we did the easy solution of start < end > then a less-than comparison would mess everything up because it would be looking for an end that doesn't exist.

Thats not to say this isn't solvable, its just not going to be a straightforward solution.

the two ways is not enough both.
the impact ..... a little bit, but not much.
the person who want to write that should know what the mean is .
no highlight of the< > in templates maybe the best way for now.

and,
vsc should not use this parser engine. really a rubbish. they need to make a new. XD

@jeff-hykin
Copy link
Owner

Well @peaceshi I've actually been working with some other guys on getting the Tree sitter parser working in VS Code.

This isssue a good example of where the tree-sitter would do a lot better.

With that said though the tree sitter is a long way off from being complete. It's running (you can download the extension) but the themes are all messed up.

@jeff-hykin
Copy link
Owner

The .cpp is def a bug, means we probably need to add an empty-string check somewhere.

I found where this was coming from and fixed the issue. The <> is still an issue though

@jeff-hykin
Copy link
Owner

closing in favor of #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Hard
Projects
None yet
Development

No branches or pull requests

3 participants