Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to get the upcoming movies for a given country. #146

Closed
virk0009 opened this issue Aug 19, 2015 · 9 comments
Closed

how to get the upcoming movies for a given country. #146

virk0009 opened this issue Aug 19, 2015 · 9 comments

Comments

@virk0009
Copy link

Hi
Thanks a lot for this great api. I am struggling to get a list of upcoming movies for india. I tried changed the default language and default country properties, but nothing works.

help will be appreciated.

regards
Parminder

@LordMike
Copy link
Collaborator

Hi,

According to the API docs for Upcoming (http://docs.themoviedb.apiary.io/#reference/movies/movieupcoming), you cannot submit Country. So you will get movies for all countries (but their names will be in your chosen language).

I believe this is partly because the data is either non-existent, or a given movie can be "upcoming" in many countries at once. You can ask in the TMDb forums for more details.

What you could do instead, is fetch each upcoming movie and inspect its country property(ies) to filter for Inidia.

Mike.

@hendrikbl
Copy link

This Feature is now implememted into the API via the region parameter: https://developers.themoviedb.org/3/movies/get-upcoming

Adding this should not be too hard :)

@LordMike LordMike reopened this Nov 30, 2016
@LordMike
Copy link
Collaborator

@hendrikbl actually, they explicitly state: "We do not yet support regional queries but this is coming soon." :)

If they do suddenly implement it - poke us again.

@hendrikbl
Copy link

@LordMike Oh okay, sorry for that. The regions page said "Region supoprt is finally here!" so I thought they implemented it. And the parameter was listed so I did not read the rest of the page.
Thank you anyways :)

@hendrikbl
Copy link

Sounds funny, but they suddenly implemented it, so heres my poke: 👈 😄

@LordMike LordMike reopened this Dec 1, 2016
@ddawson86
Copy link

Hi @LordMike, I've just started building an application with TMDb integration and your library is making life very easy so thanks! Is the region support for Showing/Upcoming movies on the road-map or do I need to roll my own methods for the time being?

@LordMike
Copy link
Collaborator

If possible, you could make a PR for this library?

It should be relatively straightforward to add a new (optional) option to the upcoming API/methods. (remember to extend one or more unit tests :))

@Naliath
Copy link
Collaborator

Naliath commented Aug 28, 2017

fixed in #222 @LordMike can you review and merge?

@LordMike
Copy link
Collaborator

@orangefrog the code contributed by @Naliath should cover your use case - could you try it out by referencing the TMDbLib project directly?

If all is well, I'll have a new version pushed to Nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants