Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ASS subtitles for external player(VLC, MX) or itself #725

Closed
wiketor opened this issue Jul 1, 2022 · 2 comments
Closed

Support ASS subtitles for external player(VLC, MX) or itself #725

wiketor opened this issue Jul 1, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@wiketor
Copy link

wiketor commented Jul 1, 2022

When using external player, it can auto download subtitles, users do not need to download subtitles manually in advance. Also, the ExoPlayer does not support ASS subtitles either.

@nalsai
Copy link
Contributor

nalsai commented Oct 3, 2022

With mpv all subtitles work perfectly.
VLC works fine with embedded subtitles, but not with external ones. This has been an issue for 6 years https://code.videolan.org/videolan/vlc-android/-/issues/1903 and no one has addressed it. It's not jellyfin's fault. This issue specifically is what needs to be fixed: https://code.videolan.org/videolan/vlc-android/-/issues/1904
MX Player is a bit weird: it doesn't show subtitles when using HW decoding. If you switch to SW or HW+ it loads the subtitles (both embedded and external) and they will continue to work, even if you switch back to HW. This might be addressable by adding some MX Player specific code, but it should really just be fixed by the developers of MX Player.

ExoPlayer is slowly adding support for ASS subtitles (google/ExoPlayer#8435) - in the next update of jellyfin-android there will be a checkbox to enable ASS support in ExoPlayer even though it is incomplete and only shows basic text.

@Maxr1998
Copy link
Member

#1 should be fixed or is a duplicate of #252, #2 is a duplicate of #587.

@Maxr1998 Maxr1998 added the duplicate This issue or pull request already exists label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants