Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGS subtitles not working when direct playing #1254

Closed
afraazali opened this issue Nov 17, 2021 · 6 comments
Closed

PGS subtitles not working when direct playing #1254

afraazali opened this issue Nov 17, 2021 · 6 comments
Labels
bug Something isn't working playback Issue related to media playback stale

Comments

@afraazali
Copy link

Describe the bug

  1. Play a file with pgs subtitles
  2. Ensure the file is being direct played
  3. Select a subtitle to display
  4. Verify the subtitles do not display

This works fine when transcoding. Using a shield pro and using a user that has transcoding enabled, I'm able to see the subtitles. The reason for transcoding shown is incompatible subtitle codec. It's odd since exoplayer does have support for pgs (google/ExoPlayer#3008).

Logs

No response

Application version

0.12.3

Where did you install the app from?

Google Play

Device information

Nvidia Shield Pro

Android version

Android

Jellyfin server version

10.7.7

@afraazali afraazali added the bug Something isn't working label Nov 17, 2021
@nielsvanvelzen nielsvanvelzen added the playback Issue related to media playback label Nov 17, 2021
@tydog98
Copy link

tydog98 commented Dec 8, 2021

Exoplayer is also not playing PGS subs for me too.

@Ky-0
Copy link

Ky-0 commented Dec 22, 2021

Yep same issue here (direct streaming). It also does not respect the forced/default flag and leaves them disabled, not a major issue in itself but annoying on the forced part as you tend to forget to enable these :)

@cirdanmiriel
Copy link

Same problem here, and also with SRT subtitles.
PGS: not loaded (and sometimes crashing the player
SRT: "loading subtitles..." for some times and then displays "subtitles can not be loaded"

Anyone here also has the problem with SRT too during direct play?

@reacocard
Copy link
Contributor

i took a quick poke around and it looks like jellyfin-androidtv requests that PGS be burned in here: https://github.com/jellyfin/jellyfin-androidtv/blob/master/app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt#L225

I think if the method was changed from ENCODE to EMBED then it would try to direct-play it instead of transcode. I don't have enough experience with android stuff to easily test building the change myself unfortunately.

@mueslimak3r
Copy link
Member

We currently don't use exoplayer to render subtitles. Currently with exoplayer, graphical subtitles need to be burned in via transcoding. Text based subtitles are displayed using our own handler. This may change in the future for formats like PGS though ASS/SSA subs will likely require burn in indefinitely unless exoplayer adds more comprehensive support or we find a way to incorporate libass into our handler

For libVLC we do use its internal renderer for some formats. LibVLC uses libass so it works quite well.

@jellyfin-bot
Copy link
Contributor

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working playback Issue related to media playback stale
Projects
None yet
Development

No branches or pull requests

8 participants