Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language tag <-> canonical language tag confusion with TranslateLocally #25

Open
jelmervdl opened this issue Jun 14, 2022 · 0 comments
Open

language tag <-> canonical language tag confusion with TranslateLocally #25

jelmervdl opened this issue Jun 14, 2022 · 0 comments

Comments

@jelmervdl
Copy link
Owner

The Ukrainian models don't work because of uk <-> ukr confusion.

translateLocally already accepts unique model identifiers instead of ambiguous language tags, but I haven't implemented that bit yet in this extension.

image

Probably caused by this bit:

https://github.com/jelmervdl/firefox-translations/blob/2181bf7852cce61fab70565c3b9d5ecbebeee1ad/extension/controller/translation/TLTranslationHelper.js#L122-L131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jelmervdl