From 4ad2d9c87543b1fbd5dc80de78beff2886562e6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Le=20Meur?= Date: Thu, 9 Mar 2023 10:45:30 +0100 Subject: [PATCH 1/3] feat: add CNAME record for github-comment-ops webhook --- dns.tf | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dns.tf b/dns.tf index a0b44f6..af6c8e5 100644 --- a/dns.tf +++ b/dns.tf @@ -72,3 +72,12 @@ resource "azurerm_dns_cname_record" "target" { ttl = 300 record = "public.publick8s.jenkins.io" } + +# CNAME record for github-comment-ops webhook +resource "azurerm_dns_cname_record" "github-comment-ops" { + name = "webhook-github-comment-ops" + zone_name = data.azurerm_dns_zone.jenkinsio.name + resource_group_name = data.azurerm_resource_group.proddns_jenkinsio.name + ttl = 300 + record = "public.privatek8s" +} From 91b547e99b2673c2fa266ecb27e312188890448f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Le=20Meur?= Date: Thu, 9 Mar 2023 10:51:11 +0100 Subject: [PATCH 2/3] fix record --- dns.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dns.tf b/dns.tf index af6c8e5..3a3acb4 100644 --- a/dns.tf +++ b/dns.tf @@ -79,5 +79,5 @@ resource "azurerm_dns_cname_record" "github-comment-ops" { zone_name = data.azurerm_dns_zone.jenkinsio.name resource_group_name = data.azurerm_resource_group.proddns_jenkinsio.name ttl = 300 - record = "public.privatek8s" + record = "public.privatek8s.jenkins.io" } From 7dd06c86e999edbd0b2088233272a767cd1ec2d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Le=20Meur?= Date: Thu, 9 Mar 2023 11:06:17 +0100 Subject: [PATCH 3/3] complete name and better comment --- dns.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dns.tf b/dns.tf index 3a3acb4..7cecc4c 100644 --- a/dns.tf +++ b/dns.tf @@ -73,8 +73,8 @@ resource "azurerm_dns_cname_record" "target" { record = "public.publick8s.jenkins.io" } -# CNAME record for github-comment-ops webhook -resource "azurerm_dns_cname_record" "github-comment-ops" { +# CNAME record for github-comment-ops GitHub App +resource "azurerm_dns_cname_record" "webhook-github-comment-ops" { name = "webhook-github-comment-ops" zone_name = data.azurerm_dns_zone.jenkinsio.name resource_group_name = data.azurerm_resource_group.proddns_jenkinsio.name