Replace Blue Ocean in default display URL (or remove the Blue Ocean plugins)

[uhafner]

Service(s)

ci.jenkins.io

Summary

All our plugin builds on ci.jenkins.io use GitHub checks to report builds results directly in pull requests. The checks provide a details URL in the pull request to directly navigate to the results in Jenkins. Currently, the display URL of the Jenkins instance is shown here. However, this details URL currently is configured to show the Blue Ocean view in Jenkins rather than the classic Jenkins view. Can you please change that so that the Blue Ocean view is not shown by default anymore. (In my opinion we can remove Blue Ocean totally, as this project has been abandoned years ago.)

(And yes: I know that I can customize the URL when logged in. But this is the main entry point for PR contributors and they should actually see Jenkins without logging in by using the current version without struggling with the deprecated Blue Ocean views.)

Reproduction steps

Example:

• General URL: https://github.com/jenkinsci/code-coverage-api-plugin/pull/324/checks?check_run_id=5527265599 (bottom link points to https://ci.jenkins.io/job/Plugins/job/code-coverage-api-plugin/job/PR-324/10/display/redirect)
• Warnings URL: https://github.com/jenkinsci/code-coverage-api-plugin/pull/324/checks?check_run_id=5527345621 (bottom link points to https://ci.jenkins.io/job/Plugins/job/code-coverage-api-plugin/job/PR-324/10/pmd)

[dduportal]

🤔 I assume that removing BlueOcean would solve the URL problem, but can't be sure. We might want to try on release.ci or infra.ci.

This is a good point that you make given the state of BlueOcean.
(Personnaly it will be hard for me to not have Blue Ocean. The Jenkins "classic" UI is barely usable for viewing pipelines but maybe I should start learning to use the pipeline graph view from Tim).

[timja]

Pipeline graph is very much WIP and really needs someone with more time to look into it.

blueocean had a whole team of people to build it...

Personally I use the Blue Ocean view a lot still...

[dduportal]

I have no idea how to setup the URL of the GitHub checks, in the scenario of "keeping BlueOcean". Where should I look? (e.g. is it the "check" plugin, or th" github check" plugin, or "github" or jenkins management page, or something else)

[KalleOlaviNiemitalo]

Seems to be configurable with the JENKINS_DISPLAYURL_PROVIDER environment variable or the jenkins.displayurl.provider Java property: JENKINS-41578, jenkinsci/display-url-api-plugin#7, https://github.com/jenkinsci/display-url-api-plugin/blob/f306dd90f7aa7117a446adbc116e0b9693a54d84/src/main/java/org/jenkinsci/plugins/displayurlapi/DisplayURLProvider.java#L178-L184

[KalleOlaviNiemitalo]

The implementation rereads the property every time, so if you call System.setProperty('jenkins.displayurl.provider', 'org.jenkinsci.plugins.displayurlapi.ClassicDisplayURLProvider') in the script console, then that should take effect immediately. Unless the HTTP redirect response is cached somewhere.

[timja]

I think this should probably be discussed on the mailing list.

[basil]

+1 from me for changing the default from Blue Ocean to the standard UI. I almost always switch from Blue Ocean to the standard UI, so this would save me a click. I still do use Blue Ocean occasionally when I need to read the console log of a build with parallel stages, so I do not think we should remove the Blue Ocean plugin yet.

[dduportal]

Delaying this issue due to not enough bandwidth.

[dduportal]

• Email sent: https://groups.google.com/g/jenkinsci-dev/c/JIRBk42NXag
• Many thanks for the pointers @KalleOlaviNiemitalo ! @smerle33 from the team is currently working on preparing the change (even if contributors vote to not to) so we are prepared.

[dduportal]

We've not seen any "no" answer (here and mailing list). Since this change is revertable, we'll proceed to apply it.

[dduportal]

Change appplied successfully (and automatically) on ci.jenkins.io. Many thanks @smerle33 .

Check: https://github.com/jenkins-infra/pipeline-library/runs/6349066600 => click on the link View more details on ci.jenkins.io redirects to https://ci.jenkins.io/job/Infra/job/pipeline-library/job/master/255/ which is the classic UI.

[KalleOlaviNiemitalo]

Huh, that link doesn't even redirect; rather, it points directly to the classic UI. So if this change is ever reverted, then these links on GitHub will keep pointing to the classic UI.

[timja]

FYI the issue that prevented this change was fixed in https://github.com/jenkinsci/display-url-api-plugin/releases/tag/display-url-api-2.3.9

[rosenkrmnv]

this fix did not help for me, neither any of the provided workarounds. Any other ideas? its quite annoying

[timja]

this fix did not help for me, neither any of the provided workarounds. Any other ideas? its quite annoying

Can you explain steps to reproduce?

[lemeurherve]

As I'd like these display/redirect links to redirect to the main build pages instead of the pipeline graph views, I tried again, checking first by changing only my user settings, then by temporarily changing the default notification URL setting of infra.ci.jenkins.io (private instance) from "default" to "Jenkins Classic":

Using the following redirect link as example: https://infra.ci.jenkins.io/job/kubernetes-jobs/job/kubernetes-management/job/main/34726/display/redirect

Here are the redirections depending on the setting value:

• "default" (current setting value on most of our instances if not all)
  • Redirect to https://infra.ci.jenkins.io/job/kubernetes-jobs/job/kubernetes-management/job/main/34726/pipeline-graph/
  • 
• "Jenkins Classic"
  • Redirect to https://infra.ci.jenkins.io/job/kubernetes-jobs/job/kubernetes-management/job/main/34726/
  • 

(I've reverted infra.ci.jenkins.io to its original setting value after the check)

As it now works as intended, I propose to set default notification URL on all instances ci.jenkins.io, infra.ci.jenkins.io and weekly.ci.jenkins.io to "Jenkins Classic", any objection?

[timja]

+1 from me

[NotMyFault]

+1

[dduportal]

+1

[lemeurherve]

Change applied on infra.ci.jenkins.io and weekly.ci.jenkins.io but rollbacked on ci.jenkins.io as I encountered the following error:

[dduportal]

Deferring issue to the 2024-06-11 milestone, time for Jay to get ready around JCasc.

[dduportal]

Update:

• @jayfranco999 was able to reproduce the JCasc error from @lemeurherve last try, on his local vagrant VM
• The issue was related to indentation in the JCasc YAML file generated by Puppet templates
• PR fix(profile::jenkinscontroller) Keep indentation to prevent JCasC misconfiguration jenkins-infra#3465 opened with a fix: we plan to deploy it to ci.jenkins.io Tuesday morning (between 07:00am and 08:00am UTC)

[dduportal]

Update:

• PR feat(ci.jenkins.io): Default notification URL switched to Jenkins Classic jenkins-infra#3468 was deployed with succes. It required 2 hotfixes:
• jenkins-infra/jenkins-infra@ded5778 => as the PR forgot to update the ci.jio hieradata (only vagrant's)
• jenkins-infra/jenkins-infra@dc673c5 => overcomes a hierdata YAML engine weird indentation behavior which most probably also bit @lemeurherve on last attempt

ci.jenkins.io is also set up with the specified setting: we can close.

Congrats @jayfranco999 on your first finished issue!