Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotated tags when releasing #25

Closed
dduportal opened this issue Sep 12, 2022 · 0 comments · Fixed by #26
Closed

Use annotated tags when releasing #25

dduportal opened this issue Sep 12, 2022 · 0 comments · Fixed by #26

Comments

@dduportal
Copy link
Contributor

In jenkins-infra/helpdesk#3084 (comment), we ran into an issue where Jenkins was not triggering builds for a given tag because the timestamp was not when the release was published but when the release-drafter tag was initially created.

This is caused by the fact the punlishing a GitHub release generates a ligthweight git tag as per https://github.com/orgs/community/discussions/4924 .

The tag is created by

gh api -X PATCH -F draft=false -F name=$version -F tag_name=$version /repos/$GITHUB_REPOSITORY/releases/$release
which publishes the GH release created by release-drafter (through the GH api).

We were able to fix the issue on our custom made library by adding the -a flag when creating our tag in the Jenkins infra (ref. jenkins-infra/pipeline-library#360) , but it is a "pure git" solution.

Not sure how to solve this issue there, maybe updating the tag created by the published release to annotate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant