Menu is broken when opening anchor links

[daniel-beck]

Clicking "dependencies" on https://plugins.jenkins.io/matrix-auth/ changes the URL to https://plugins.jenkins.io/matrix-auth/#dependencies.

Opening a link to "https://plugins.jenkins.io/matrix-auth/#dependencies" takes you there directly, but the menu doesn't change accordingly:

[halkeye]

Do you see anything in your console or anything? I just tried it and things seem to work right for me.

The tabs are pure javascript so its surprising it works in some case and some other places. if its still happening, which browser/etc combo?

[daniel-beck]

The important part is opening the link in a new tab. That's the whole point of it being a separate URL, no? That one can link to a tab from elsewhere?

tabs.mov

[halkeye]

Oh oh. Okay. So it's not that the functionality doesn't work, it's that the ui doesn't update on new tab. My guess is its the new header linking support. I'll take a look

…

On Mon., Dec. 6, 2021, 10:51 a.m. Daniel Beck, ***@***.***> wrote: The important part is opening the link in a new tab. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#885 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA24B2RKJIMPM6D4MZFWTLUPUAZTANCNFSM5JOV34QA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[halkeye]

Had to revert. I liked the new solution, but it caused rendering issues.