Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin hosting request for TRACEABLE-PLUGIN #3974

Closed
dhruv-singhal-github opened this issue Jun 17, 2024 · 8 comments
Closed

Plugin hosting request for TRACEABLE-PLUGIN #3974

dhruv-singhal-github opened this issue Jun 17, 2024 · 8 comments
Labels
hosting-request Request to host a component in jenkinsci needs-fix security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request

Comments

@dhruv-singhal-github
Copy link

Repository URL

https://github.com/Traceableai/traceable-xast-jenkins-plugin

New Repository Name

TRACEABLE-PLUGIN

Description

This is a plugin by Traceable AI that helps in API Security Testing by finding vulnerabilities in very early stages, giving developers and Product security engineers more time and context to prioritize mitigation of vulnerabilities and build resilient systems by scanning APIs for vulnerabilities by changing the data in the existing API specifications as required to introduce vulnerabilities.

GitHub users to have commit permission

@dhruv-singhal-github @samarth-gupta-traceable

Jenkins project users to have release permission

dhruv_singhal
traceableai

Issue tracker

Jira

@dhruv-singhal-github dhruv-singhal-github added the hosting-request Request to host a component in jenkinsci label Jun 17, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.361</jenkins.version> to at least 2.440.3 in your pom.xml. Take a look at the baseline recommendations.
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: traceableai (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: dhruv_singhal, traceableai (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: dhruv-singhal-github samarth-gupta-traceable
  • ⛔ Required: The 'artifactId' from the pom.xml (traceable) is incorrect, it should be traceable-plugin ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.6)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Jun 17, 2024
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 7 finding(s) 🔍.

Please follow the instructions below for every identified issues:

  • Implement the recommended fix to address the issue.
  • If you think it's a false positive, suppress the warning directly within the code.
  • Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

  • If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
  • If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

TraceableASTGenerateReportAction.java#30
Field should be reviewed whether it stores a password and is serialized to disk: traceableCliKeyFileName
TraceableASTGenerateReportAction.java#27
Field should be reviewed whether it stores a password and is serialized to disk: clientToken

Jenkins: Generally unsafe method calls

You can find detailed information about this finding here.

TraceableASTGenerateReportAction.java#63
Potentially unsafe invocation of Runtime#exec
TraceableASTInitAndRunStepBuilder.java#469
Potentially unsafe invocation of Runtime#exec
TraceableASTInitStepBuilder.java#430
Potentially unsafe invocation of Runtime#exec
TraceableASTRunStepBuilder.java#90
Potentially unsafe invocation of Runtime#exec
TraceableApiInspectorStepBuilder.java#104
Potentially unsafe invocation of Runtime#exec

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Jun 17, 2024
@dhruv-singhal-github
Copy link
Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: traceableai (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: dhruv_singhal, traceableai (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: dhruv-singhal-github samarth-gupta-traceable
  • ⛔ Required: The 'artifactId' from the pom.xml (traceable-plugin) is incorrect, it should be traceable-plugin ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@dhruv-singhal-github
Copy link
Author

/hosting re-check

1 similar comment
@dhruv-singhal-github
Copy link
Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: dhruv-singhal-github samarth-gupta-traceable
  • ⛔ Required: The 'artifactId' from the pom.xml (TRACEABLE) should be all lower case
  • ⛔ Required: The 'artifactId' from the pom.xml (TRACEABLE) is incorrect, it should be traceable-plugin ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hosting-request Request to host a component in jenkinsci needs-fix security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request
Projects
None yet
Development

No branches or pull requests

2 participants