Host a plugin: teambition-devops-plugin

[gqlhappy11]

Repository URL

https://github.com/teambition/devops-jenkins-plugin

New Repository Name

teambition-devops-plugin

Description

为Teambition DevOps应用定制的插件，协助使用Teambition DevOps应用的用户，完善项目管理功能：更新流水线功能模块的发布状态、根据代码提交记录关联Teambition任务和流水线构建记录等

GitHub users to have commit permission

@gqlhappy11

Jenkins project users to have release permission

gqlhappy11

Issue tracker

GitHub issues

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.332.4</jenkins.version> to at least 2.440.3 in your pom.xml. Take a look at the baseline recommendations.
• ⛔ Required: The parent pom version '4.50' should be at least '4.85' or higher.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: gqlhappy11 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: gqlhappy11 (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

• /audit-ok => the audit is complete, the hosting can continue 🎉.
• /audit-skip => the audit is not necessary, the hosting can continue 🎉.
• /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.29.6)

[jenkins-cert-app]

❌ Jenkins Security Scan failed.
The Security team was notified about this.

[gqlhappy11]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: Your baseline specified does not meet the minimum Jenkins version required, please update <jenkins.version>2.332.4</jenkins.version> to at least 2.440.3 in your pom.xml. Take a look at the baseline recommendations.
• ⛔ Required: The parent pom version '4.50' should be at least '4.85' or higher.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: gqlhappy11 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: gqlhappy11 (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[gqlhappy11]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[gqlhappy11]

/hosting host

[NotMyFault]

/request-security-scan

[jenkins-cert-app]

❌ Jenkins Security Scan failed.
The Security team was notified about this.

[mawinter69]

• You're using io.jenkins.plugins as the root package of your plugin. Please use a plugin specific root package, e.g. io.jenkins.plugins.teambition
• bom version is not in sync with jenkins version: https://github.com/teambition/devops-jenkins-plugin/blob/24e324b733545f0f0d25449cc251e7a5ab053475/pom.xml#L43
• please use the Apache HttpComponents Client 4.x API plugin instead of directly using httpclient https://github.com/teambition/devops-jenkins-plugin/blob/24e324b733545f0f0d25449cc251e7a5ab053475/pom.xml#L89
• do not specify a version for workflow-job here https://github.com/teambition/devops-jenkins-plugin/blob/24e324b733545f0f0d25449cc251e7a5ab053475/pom.xml#L64, the version is defined by the bom already

[gqlhappy11]

/hosting host

[NotMyFault]

You can't host the plugin yourself, we'll need to review it still.On 2. Aug 2024, at 09:21, liz ***@***.***> wrote: /hosting host —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

[gqlhappy11]

Is it ready to host?

[gqlhappy11]

Hello?

[Kevin-CB]

Sorry the delay, I'll investigate why the Security scan is failing

[Kevin-CB]

It looks like there is a bug with Lombok version, could you try bumping it to at least v1.18.22 to fix this issue: projectlombok/lombok#2681.

Then try rerunning the scan, it should fix the error.

[gqlhappy11]

/request-security-scan

[jenkins-cert-app]

The Jenkins Security Scan discovered 1 finding(s) 🔍.

Please follow the instructions below for every identified issues:

• Implement the recommended fix to address the issue.
• If you think it's a false positive, suppress the warning directly within the code.
• Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

• If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
• If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

---

Result of hasPermission call is ignored

You can find detailed information about this finding here.

DevOpsGlobalConfig.java#116

The result of the call is ignored

[gqlhappy11]

/request-security-scan

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[gqlhappy11]

Is it ready to host now?

[NotMyFault]

• Please create a .mvn folder within the repository root with the following files: https://github.com/jenkinsci/archetypes/tree/master/common-files/.mvn
• Please create a .github folder within the repository root with the following files and subdirectories: https://github.com/jenkinsci/archetypes/tree/master/common-files/.github
  Replace ${artifactId} where needed
• Update your Jenkinsfile with the content from https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile
• Remove all dependencies from your pom.xml, the plugin doesn't actually depend on.
• The plugin does not compile via mvn clean verify package, this is needed to build on our infra

[mawinter69]

Would it be possible to replace the dependency to fastjson2 (https://github.com/teambition/devops-jenkins-plugin/blob/a7165c395aff84d847f0fccc9e9aad329c060685/pom.xml#L94) with

<dependency>
    <groupId>io.jenkins.plugins</groupId>
    <artifactId>json-api</artifactId>
</dependency>

That would avoid that to pack the 2MiB fastjson2 library inside the hpi and make use of the library plugin for org.json:json

[gqlhappy11]

I have fixed all problems mentioned. Please check again, is it ready to host now?

[mawinter69]

One last comment. You property files for the texts have chinese as default and english as additional language (*_en.properties). For anyone that has not english as the default language in the browser and also no chinese will see the everything in chinese. It would be better to make english the default.

[gqlhappy11]

The default language has been changed to english. Please have a look again.

[mawinter69]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[mawinter69]

Looks good from my point of view, but I'm lacking the power to host it

[timja]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/teambition-devops-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

Welcome aboard!