Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux and OSX to CI #424

Closed
dblock opened this issue Nov 11, 2021 · 6 comments · Fixed by #487
Closed

Add Linux and OSX to CI #424

dblock opened this issue Nov 11, 2021 · 6 comments · Fixed by #487

Comments

@dblock
Copy link
Member

dblock commented Nov 11, 2021

Feature Request

Run tests on Linux and MacOS, useful for ensuring things like #423 don’t happen.

Could easily get rid of AppVeyor for GHA. I can PR on top of dblock@a648c24 If there’s interest

@nre-ableton
Copy link
Contributor

I'm not a huge fan of Travis, so I'm not opposed to changing the CI to something else. However, I'm not the owner of this repo and the decision is not mine to make. It would probably be worth exploring whether the Jenkins organization has a general recommendation on CI infrastructure.

@dblock
Copy link
Member Author

dblock commented Nov 11, 2021

Not a fan of Travis either, or Jenkins for that matter :) I mean GitHub actions.

@nre-ableton
Copy link
Contributor

I asked around a bit on gittr's jenkinsci room what CI we should use, and while they agreed that GitHub Actions was preferable to AppVeyor/Travis, it was recommended that we use the jenkinsci Jenkins instance. There's already a Jenkinsfile in the repo, so it seems that someone set this up in the past. However, I couldn't find any previous builds, so I'm not sure what's going on... I'll look into this to see if there's an easy way to get our project building there.

Regardless, since this is a Jenkins-based framework, it seems that testing on Jenkins would indeed be more logical than other CI providers.

@dblock
Copy link
Member Author

dblock commented Nov 15, 2021

No hard feelings about which CI we use @nre-ableton! My preference has always been GHA because it's zero-setup, but if we can get all platforms on jenkins-ci, great.

@nre-ableton nre-ableton changed the title Add Linux and OSX to CI (switch to GHA?) Add Linux and OSX to CI Jan 4, 2022
@nre-ableton
Copy link
Contributor

Although GitHub actions are convenient, we'd like to try and get Jenkins working if possible. The Jenkins infrastructure team reached out to us, and suggested we file an issue, which I have done here: jenkins-infra/helpdesk#2776.

@nre-ableton
Copy link
Contributor

We will add Linux and replace Windows in #486. Mac support will be provided via GitHub actions. I'll make a PR based on #425 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants