Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies of flattened POM of latest release do not match MANIFEST.MF #233

Closed
basil opened this issue Sep 12, 2023 · 0 comments · Fixed by #234
Closed

Dependencies of flattened POM of latest release do not match MANIFEST.MF #233

basil opened this issue Sep 12, 2023 · 0 comments · Fixed by #234
Labels
bug Something isn't working

Comments

@basil
Copy link
Member

basil commented Sep 12, 2023

#229 pulled in jenkinsci/analysis-pom-plugin#737 which pulled in jenkinsci/plugin-pom#724 which pulled in mojohaus/flatten-maven-plugin#329 which broke the flattened POM: it no longer declares the plugin-to-plugin dependencies on commons-text-api and commons-lang3-api as explained in jenkinsci/bom#2484 (comment).

@basil basil added the bug Something isn't working label Sep 12, 2023
MarkEWaite added a commit to MarkEWaite/bom that referenced this issue Sep 16, 2023
…enkinsci#2471)"

jenkinsci#2484 describes the unexpected
addition of commons-text-api as a new dependency for many consumers of
the plugin bill of materials.

Rather than having more and more plugins adding dependencies on the
commons-text-api or the commons-lang3-api plugin, let's keep the
checks-api dependency at 2.0.0 instead of 2.0.1.

jenkinsci/checks-api-plugin#233 is the issue
reported to the checks-api plugin.  Once that issue is resolved, we
should be able to use more recent checks-api plugin versions.

Dependency updates that had to add commons-text-api included:

* jenkinsci/bitbucket-kubernetes-credentials-plugin#133
* jenkinsci/elastic-axis-plugin#309
* jenkinsci/nodelabelparameter-plugin#265
* jenkinsci/testng-plugin-plugin#244

This reverts commit 729dfb2.
MarkEWaite added a commit to MarkEWaite/checks-api-plugin that referenced this issue Sep 16, 2023
Fixes jenkinsci#233 (at least partially)

The plugin depends on Apache commons lang3 but did not declare it
directly in the pom.

Declare it in the pom with hope that will help to resolve the plugin
bill of materials issue described at
jenkinsci/bom#2484 (comment)
MarkEWaite added a commit to MarkEWaite/bom that referenced this issue Sep 17, 2023
…enkinsci#2471)"

jenkinsci#2484 describes the unexpected
addition of commons-text-api as a new dependency for many consumers of
the plugin bill of materials.

Rather than having more and more plugins adding dependencies on the
commons-text-api or the commons-lang3-api plugin, let's keep the
checks-api dependency at 2.0.0 instead of 2.0.1.

jenkinsci/checks-api-plugin#233 is the issue
reported to the checks-api plugin.  Once that issue is resolved, we
should be able to use more recent checks-api plugin versions.

Dependency updates that had to add commons-text-api included:

* jenkinsci/bitbucket-kubernetes-credentials-plugin#133
* jenkinsci/elastic-axis-plugin#309
* jenkinsci/nodelabelparameter-plugin#265
* jenkinsci/testng-plugin-plugin#244

This reverts commit 729dfb2.
MarkEWaite added a commit to jenkinsci/bom that referenced this issue Sep 17, 2023
* Pin previous credentials-binding release for LTS profiles

The most recent release of the credentials-binding plugin adds masking
for base64 credentials.  That's a nice improvement.  Unfortunately,
it causes one of the config-file-provider tests to fail.

Adapt older bom profiles to "Bump credentials-binding (#2509)" by
retaining the current version of the credentials binding plugin on
the weekly release and pinning the previous credentials binding plugin
release on the LTS releases.

Could exclude the test failure on all releases, but it seemed better
to be able to detect test failures from the weekly release even if we
can't yet test the new version with the LTS releases.

This partially reverts commit bab8257.

* Revert "Bump checks-api.version from 2.0.0 to 2.0.1 in /bom-weekly (#2471)"

#2484 describes the unexpected
addition of commons-text-api as a new dependency for many consumers of
the plugin bill of materials.

Rather than having more and more plugins adding dependencies on the
commons-text-api or the commons-lang3-api plugin, let's keep the
checks-api dependency at 2.0.0 instead of 2.0.1.

jenkinsci/checks-api-plugin#233 is the issue
reported to the checks-api plugin.  Once that issue is resolved, we
should be able to use more recent checks-api plugin versions.

Dependency updates that had to add commons-text-api included:

* jenkinsci/bitbucket-kubernetes-credentials-plugin#133
* jenkinsci/elastic-axis-plugin#309
* jenkinsci/nodelabelparameter-plugin#265
* jenkinsci/testng-plugin-plugin#244

This reverts commit 729dfb2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant