Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code Improvements #42

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Conversation

darxriggs
Copy link
Contributor

These are just some minor code improvements.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, please revert the getActiveInstance() changes. Behavior of getInstance() changes was changed few times in incompatible way, better to use Jenkins.get() which will be available after 2.138.x

@darxriggs
Copy link
Contributor Author

I just removed the last commit containing the getActiveInstance() changes.

@oleg-nenashev
Copy link
Member

I should have fixed CI now, let's see. https://groups.google.com/forum/#!topic/jenkinsci-dev/v9d-XosOp2s

@oleg-nenashev oleg-nenashev changed the title Code Improvements Minor code Improvements Aug 15, 2019
@oleg-nenashev oleg-nenashev merged commit aa02984 into jenkinsci:master Aug 15, 2019
@darxriggs darxriggs deleted the improvements branch August 15, 2019 17:17
@darxriggs
Copy link
Contributor Author

I think I am nearly done for now with changes.

Just two more points:

  1. Please have a look at https://github.com/jenkinsci/custom-tools-plugin/branches and consider removing the stale branches.
  2. The code has a lot of trailing whitespace noise. Shall I prepare a pull request cleaning this up? Or do you fear a) too many merge conflicts with open pull request and b) cumbersome navigation when it comes to git blame?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants