Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a translucent color for cards/tables/tabs #553

Merged

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 8, 2024

Small one to stop using translucent colors for cards/tables/tabs. This isn't really an issue in 'core' but in the Design Library the components can look a little odd when overlaying a colorful background (the color bleeds through). There shouldn't be any differences in 'core', apart from perhaps an unnoticeable hue change.

Before
image

After
image

Testing done

  • Cards/tables/tabs look as expected

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik requested a review from a team as a code owner December 8, 2024 15:32
@timja timja added the enhancement New feature or request label Dec 8, 2024
@timja timja merged commit a3ea73d into jenkinsci:master Dec 8, 2024
18 checks passed
@janfaracik janfaracik deleted the dont-use-translucent-card-colours branch December 8, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants