Ignore conflict while removing container #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances we try to remove docker container while it is still being terminated. Seems such a race condition can happen with pipelines as we detect both Pipeline job and PlaceholderTask completion.
PlaceholderExecutable:ExecutorStepExecution.PlaceholderTask{runId=CompileTest#22494,label=docker-2ae12755b 75761,context=CpsStepContext[4:node]:Owner[CompileTest/22494:CompileTest #22494],cookie=561ba1da-fd51-4ee6-9bc3-5d4bb75a9fd0,auth=null} seems to be finished ... 2018-11-15 14:00:06.624+0000 [id=2063173] FINE c.n.j.p.d.s.DockerOnceRetentionStrategy#done: terminating docker-2ae12755b75761 since CompileTestTest #544 seems to be finished 2018-11-15 14:00:06.625+0000 [id=2063198] INFO i.j.docker.DockerTransientNode$1#println: Disconnected computer for slave 'docker-2ae12755b75761'. 2018-11-15 14:00:06.625+0000 [id=2063198] INFO i.j.docker.DockerTransientNode$1#println: Removed Node for slave 'docker-2ae12755b75761'. 2018-11-15 14:00:07.005+0000 [id=2062533] INFO i.j.docker.DockerTransientNode$1#println: Stopped container '056930a8ce961fabcd357f7c349c36aad55242075a9af838b963c4b27fddc4e9' for slave 'docker-2ae12755b75761'. 2018-11-15 14:00:07.005+0000 [id=2063233] INFO i.j.docker.DockerTransientNode$1#println: Stopped container '056930a8ce961fabcd357f7c349c36aad55242075a9af838b963c4b27fddc4e9' for slave 'docker-2ae12755b75761'. 2018-11-15 14:00:07.011+0000 [id=2062533] SEVERE i.j.docker.DockerTransientNode$1#error: Failed to remove container '056930a8ce961fabcd357f7c349c36aad55242075a9af838b963c4b27fddc4e9' for slave 'docker-2ae12755b75761' due to exception: com.github.dockerjava.api.exception.ConflictException: {"message":"removal of container 056930a8ce961fabcd357f7c349c36aad55242075a9af838b963c4b27fddc4e9 is already in progress"}Not sure about the root cause for this, but at least we can ignore conflict in container removal to avoid spamming the logs