Rework DockerBuilderPublisher to work under dockerNode() #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DockerBuilderPublisher couldn't be run without providing a cloud name under dockerNode(), because dockerNode never did set a cloudName on the DockerTransientNode. This reworks DockerBuilderPublisher to be capable of launching the building on a DockerApi directly, because thats what it actually needs, and thats what dockerNode has. Signed-off-by: Anton Lundin <glance@acc.umu.se>
|
Any possibility to get this reviewed and merged? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DockerBuilderPublisher couldn't be run without providing a cloud name
under dockerNode(), because dockerNode never did set a cloudName on the
DockerTransientNode.
This reworks DockerBuilderPublisher to be capable of launching the
building on a DockerApi directly, because thats what it actually needs,
and thats what dockerNode has.
Signed-off-by: Anton Lundin glance@acc.umu.se