Enhance attach connection method and try to fix unit tests #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we implement equals, we need to implement hashcode too.
Unnecessary else
Added javaExe, jvmArgs and entryPointCmd fields. We can now fully customise the cmd we run to run the slave code. This lets us set JVM args like -Xmx500m etc.
Removed unused method
Refactored code to avoid repetition of dockerNode pipeline syntax. Added in -Xmx250m JVM arg in an attempt to fix persistent JVM OOM errors on unit-tests during jenkinsci builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep getting unit-test failures on DockerNodeStepTest on jenkinsci builds ... but these don't seem to happen when run locally. I've seen memory-allocation failures from the JVM which might be each JVM allocating 25% of host ram on a host running more than 3 docker containers at once.
So, this enhances the "attach" connect method to make the command it runs fully configurable (like we can with JNLP nodes) and then uses that to specify a -Xmx limit in the dodgy test.