-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH Build Agents (ssh-slaves) 1.31.7 Breaks Docker Plugin (1.2.2) #834
Comments
I've made a PR (#835) that I should fix the bug (I think). |
@pjdarton I will try it tonight. |
@pjdarton My apologies, these plugins are jar files, i dont know how to build one in order to test your PR. |
I've made another PR (#836) which seems to fix the |
+1 @pjdarton : Hey Peter, we have some issues now as our Jenkins Master cannot connect to the Jenkins Agents running in our "docker cloud". What is missing at the moment to get your PR merged? Maybe i can help with something? |
It was blocked pending testing. If you're in a position where you need this fix, you're in a perfect position to test this fix 😁 If that fixes it for you, comment in #835 telling everyone of your test results - once I'm confident that it all works then I'll merge it in. |
Hey Peter, the fix works for me. I have updated the SSH Agent plugin to 1.32.0 and also installed the docker-plugin HPI file from here https://repo.jenkins-ci.org/incrementals/io/jenkins/docker/docker-plugin/1.2.3-rc974.720c6519100d/ From my site it looks good. |
PR was merged yesterday and a release (version 1.2.3) done today. |
Version report
Jenkins and plugins versions report:
Reproduction steps
Results
Expected result:
Docker container deploys, build is run on container, container is destroyed on completion.
Actual result:
Docker container deploys but SSH connection fails so build agent does not get deployed, job fails.
System log:
The text was updated successfully, but these errors were encountered: