diff --git a/cli/src/main/java/hudson/cli/CLI.java b/cli/src/main/java/hudson/cli/CLI.java index 6abf4ae80f10..4525dd75901e 100644 --- a/cli/src/main/java/hudson/cli/CLI.java +++ b/cli/src/main/java/hudson/cli/CLI.java @@ -71,6 +71,7 @@ /** * CLI entry point to Jenkins. */ +@SuppressFBWarnings(value = "CRLF_INJECTION_LOGS", justification = "We don't care about this behavior") public class CLI { private CLI() {} diff --git a/cli/src/main/java/hudson/cli/DiagnosedStreamCorruptionException.java b/cli/src/main/java/hudson/cli/DiagnosedStreamCorruptionException.java index a701cb303347..e84d4e3cf700 100644 --- a/cli/src/main/java/hudson/cli/DiagnosedStreamCorruptionException.java +++ b/cli/src/main/java/hudson/cli/DiagnosedStreamCorruptionException.java @@ -1,5 +1,6 @@ package hudson.cli; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.PrintWriter; import java.io.StreamCorruptedException; import java.io.StringWriter; @@ -36,6 +37,7 @@ public byte[] getReadAhead() { } @Override + @SuppressFBWarnings(value = "INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE", justification = "Jenkins handles this issue differently or doesn't care about it") public String toString() { StringBuilder buf = new StringBuilder(); buf.append(super.toString()).append("\n"); diff --git a/core/src/main/java/hudson/model/Descriptor.java b/core/src/main/java/hudson/model/Descriptor.java index 716b73031510..f25ccd4205cb 100644 --- a/core/src/main/java/hudson/model/Descriptor.java +++ b/core/src/main/java/hudson/model/Descriptor.java @@ -30,6 +30,7 @@ import edu.umd.cs.findbugs.annotations.CheckForNull; import edu.umd.cs.findbugs.annotations.NonNull; import edu.umd.cs.findbugs.annotations.Nullable; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import hudson.BulkChange; import hudson.DescriptorExtensionList; import hudson.ExtensionList; @@ -755,6 +756,7 @@ public String getHelpFile(final String fieldName) { return getHelpFile(getKlass(), fieldName); } + @SuppressFBWarnings(value = "SBSC_USE_STRINGBUFFER_CONCATENATION", justification = "no big deal") public String getHelpFile(Klass clazz, String fieldName) { HelpRedirect r = helpRedirect.get(fieldName); if (r != null) return r.resolve(); diff --git a/src/spotbugs/excludesFilter.xml b/core/src/spotbugs/excludesFilter.xml similarity index 91% rename from src/spotbugs/excludesFilter.xml rename to core/src/spotbugs/excludesFilter.xml index d3fe630c371a..99921b246186 100644 --- a/src/spotbugs/excludesFilter.xml +++ b/core/src/spotbugs/excludesFilter.xml @@ -353,45 +353,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -417,7 +378,6 @@ - @@ -504,10 +464,6 @@ - - - -