Make creation of user optional #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the creation of jenkins user and group is protected by if !defined. This can be extremely annoying in cases where code is trying to install a competing jenkins user/group. In my specific case, I'm blocked by this code leading to duplicate jenkins users (and I need my definition to be created first). In general, I thought that these kinds of issue were resolvable via enusre that classes were including in a certain order, but I cannot seem to resove it in my specific use case which involves: * nested class includes * serialized user resources from hiera * create_resources
bodepd
force-pushed
the
make_user_creation_optional
branch
from
df2302d
to
716fa44
Compare
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
These failures do not seem to have anything to do with my patch. |
rtyler
pushed a commit
that referenced
this pull request
Jan 29, 2015
Make creation of user optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the creation of jenkins user
and group is protected by if !defined. This
can be extremely annoying in cases where code
is trying to install a competing jenkins user/group.
In my specific case, I'm blocked by this code
leading to duplicate jenkins users (and I need
my definition to be created first). In general,
I thought that these kinds of issue were resolvable
via enusre that classes were including in a certain
order, but I cannot seem to resove it in my specific use
case which involves: