Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make creation of user optional #235

Merged
merged 1 commit into from
Jan 29, 2015

Conversation

bodepd
Copy link
Contributor

@bodepd bodepd commented Jan 14, 2015

Currently, the creation of jenkins user
and group is protected by if !defined. This
can be extremely annoying in cases where code
is trying to install a competing jenkins user/group.

In my specific case, I'm blocked by this code
leading to duplicate jenkins users (and I need
my definition to be created first). In general,
I thought that these kinds of issue were resolvable
via enusre that classes were including in a certain
order, but I cannot seem to resove it in my specific use
case which involves:

  • nested class includes
  • serialized user resources from hiera
  • create_resources

Currently, the creation of jenkins user
and group is protected by if !defined. This
can be extremely annoying in cases where code
is trying to install a competing jenkins user/group.

In my specific case, I'm blocked by this code
leading to duplicate jenkins users (and I need
my definition to be created first). In general,
I thought that these kinds of issue were resolvable
via enusre that classes were including in a certain
order, but I cannot seem to resove it in my specific use
case which involves:
* nested class includes
* serialized user resources from hiera
* create_resources
@bodepd bodepd force-pushed the make_user_creation_optional branch from df2302d to 716fa44 Compare January 14, 2015 12:09
@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@bodepd
Copy link
Contributor Author

bodepd commented Jan 14, 2015

These failures do not seem to have anything to do with my patch.

@rtyler rtyler added this to the 1.4.0 - Smithers milestone Jan 29, 2015
rtyler pushed a commit that referenced this pull request Jan 29, 2015
@rtyler rtyler merged commit f069b53 into voxpupuli:master Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants