Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert raw execs of puppet_helper.groovy to jenkins::cli::exec define #285

Merged

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented May 3, 2015

No description provided.

@rtyler
Copy link

rtyler commented May 3, 2015

Hooray abstractions

rtyler pushed a commit that referenced this pull request May 3, 2015
convert raw execs of puppet_helper.groovy to jenkins::cli::exec define
@rtyler rtyler merged commit 7f255a3 into voxpupuli:master May 3, 2015
@rtyler rtyler added this to the 1.4.0 - Smithers milestone May 3, 2015
@jhoblitt
Copy link
Member Author

jhoblitt commented May 3, 2015

Indeed. :)

Hopefully, most of these will get replaced with a native type. I wrote jenkins::cli::exec when I was trying jenkins for the first time (at the end of march) and hadn't yet appreciated the complexities of dealing with the cli jar or some of the obstacles in the jenkins API. Implementing types and providers turned out to be much more difficult than I originally estimated. I've essentially finished a jenkins_user resource type but want to do some refactoring before PRing it.

@jhoblitt jhoblitt deleted the maint/convert-to-jenkins-cli-exec branch May 4, 2015 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants