Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/puppet helper util #292

Merged
merged 4 commits into from
May 7, 2015

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented May 6, 2015

No description provided.

@jhoblitt
Copy link
Member Author

jhoblitt commented May 6, 2015

This is essentially a no-op but its foundational for planned PRs that I'm attempting to break down into easily digested patch sets.

@jhoblitt jhoblitt force-pushed the feature/puppet_helper-util branch from 3c6d5a3 to 3af2fcf Compare May 6, 2015 17:47
@jhoblitt
Copy link
Member Author

jhoblitt commented May 6, 2015

I've amended and repushed one of the commit messages to note that this is a breaking change to the output of user_info(). There are no in-tree consumers of this method so, AFAIK, it should be safe.

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Joshua Hoblitt added 4 commits May 6, 2015 16:29
This field is used to access the object returned by getBinding().  This object
is needed to access to a number of facilities, including the stdin.
Private methods don't appear to be "prviate" under groovy.  This utility class
is for methods that should not be exposed as CLI options via the Action class.
…_helper

This also changes the format of the JSON document generated by user_info().

* removed api_token; split into api_toke_public & api_token_plain
* changed public_keys; it is now a single list element per ssh public key
* added password
@jhoblitt jhoblitt force-pushed the feature/puppet_helper-util branch from 3af2fcf to c400514 Compare May 6, 2015 23:29
@rtyler rtyler added this to the 1.5.0 - Jennings milestone May 7, 2015
rtyler pushed a commit that referenced this pull request May 7, 2015
@rtyler rtyler merged commit ad774dc into voxpupuli:master May 7, 2015
@jhoblitt jhoblitt deleted the feature/puppet_helper-util branch May 7, 2015 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants