Maint/fix resource relationships #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 11, 2015 12:29
Introduced by: voxpupuli@979cb01 Classes/defines which include the jenkins::cli class assume that they can use the cli even if $::jenkins::cli == false. This breaks the top level anchor pattern. The cli param should either be deprecated and essentially hardwired to true or attempting to use cli functionality without this param set should fail; either option is a backwards incompatible change. As an attempt to preserve backwards compatibility, there are includes and resource relationships being scattered throughout this module.
Note that idempotence is not checked for as this appears to be broken with at least jenkins 1.613.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I manually resolved this conflict and merged it into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #294