Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template in the jenkins::job #376

Merged
merged 2 commits into from
Sep 27, 2015
Merged

Add template in the jenkins::job #376

merged 2 commits into from
Sep 27, 2015

Conversation

oloc
Copy link
Contributor

@oloc oloc commented Sep 17, 2015

I propose this improvement to add an option to avoid copy/paste files.

Very helpfull when we use something like:

  $jobs = hiera('jenkins::jobs')
  create_resources(jenkins::job, $jobs)

And a hiera like this one:

jenkins::jobs :
  petclinic-build:
    jobname: 'petclinic-build'
    config: ''
    source: 'g10b/petclinic-build.xml'

@rtyler rtyler added this to the 1.6.0 - Kato milestone Sep 17, 2015
@rtyler
Copy link

rtyler commented Sep 17, 2015

I like it! Would it be possible for you to add an rspec-puppet test case to validate the behavior before I merge it?

@rtyler rtyler added needs-feedback Further information is requested enhancement New feature or request labels Sep 17, 2015
@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oloc
Copy link
Contributor Author

oloc commented Sep 23, 2015

I'm not comfortable with rspec-puppet. You have to check and improve my last commit. I might be wrong.

@rtyler
Copy link

rtyler commented Sep 23, 2015

@oloc No worries! I'll take a look and tweak this as necessary for merging

rtyler pushed a commit that referenced this pull request Sep 27, 2015
Add template in the jenkins::job
@rtyler rtyler merged commit e4815b5 into voxpupuli:master Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-feedback Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants