Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rspec-puppet raise_error warning #378

Merged
merged 1 commit into from
Sep 17, 2015

Conversation

jhoblitt
Copy link
Member

Resolves this warning:

WARNING: Using the `raise_error` matcher without providing a specific
error or message risks false positives, since `raise_error` will match
when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`,
potentially allowing the expectation to pass without even executing the
method you are intending to call. Instead consider providing a specific
error class or message. This message can be supressed by setting:
`RSpec::Expectations.configuration.warn_about_potential_false_positives
= false`.

Resolves this warning:

    WARNING: Using the `raise_error` matcher without providing a specific
    error or message risks false positives, since `raise_error` will match
    when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`,
    potentially allowing the expectation to pass without even executing the
    method you are intending to call. Instead consider providing a specific
    error class or message. This message can be supressed by setting:
    `RSpec::Expectations.configuration.warn_about_potential_false_positives
    = false`.
@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rtyler rtyler added this to the 1.6.0 - Kato milestone Sep 17, 2015
rtyler pushed a commit that referenced this pull request Sep 17, 2015
@rtyler rtyler merged commit ce8b98b into voxpupuli:master Sep 17, 2015
@jhoblitt jhoblitt deleted the maint/rspec-raise_error-warniing branch April 15, 2016 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants