Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate token isn't null before sending to slack #527

Closed
timja opened this issue Feb 22, 2019 · 1 comment
Closed

Validate token isn't null before sending to slack #527

timja opened this issue Feb 22, 2019 · 1 comment

Comments

@timja
Copy link
Member

timja commented Feb 22, 2019

We should fail early if we can't find a credential, and not fail with "404 not found check the logs"

"URL is sending ?token=null -- you can see it under FINE logging."

Originally posted by @CodeMonk in #525 (comment)
@timja
Copy link
Member Author

timja commented Mar 16, 2019

Fixed in #541

@timja timja closed this as completed Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timja