Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Missing "Zeichenkette" filter element in variables #232

Closed
Schello805 opened this issue Jan 2, 2018 · 3 comments · Fixed by #275
Closed

WebUI: Missing "Zeichenkette" filter element in variables #232

Schello805 opened this issue Jan 2, 2018 · 3 comments · Fixed by #275
Labels
💡 enhancement-ideas New feature or change request 🏷️ WebUI This refs the WebUI component

Comments

@Schello805
Copy link

Schello805 commented Jan 2, 2018

I actually find a new issue. It is the missing filtering element "Zeichenkette" in the overview of the variables of the Raspberrymatic and also in the variables selection, during generating a programm.
variables
variables2

@jens-maus
Copy link
Owner

Thanks for the report. However, the same applies to a plain CCU2 because there "Zeichenkette" is also not part of the Filter section. Thus, this isn't really a bug in RaspberryMatic but more a feature request. Thus, I will change it accordingly and flag it accordingly.

@jens-maus jens-maus changed the title Missing filter element in variables WebUI: Missing "Zeichenkette" filter element in variables Jan 2, 2018
@jens-maus jens-maus added 💡 enhancement-ideas New feature or change request 🏷️ WebUI This refs the WebUI component labels Jan 2, 2018
@jp112sdl
Copy link
Contributor

jp112sdl commented Jan 5, 2018

Wäre auch ein Filtern nach CUXD möglich (sofern man das Addon installiert hat)?

bildschirmfoto 2018-01-05 um 22 53 27

@HMside
Copy link
Contributor

HMside commented Feb 28, 2018

With this three patches we can include the filter for string-variables. This patches are created with the RaspberryMatic files note with the CCU2 files.

/www/webui/webui.js

--- webui.js.orig
+++ webui.js
@@ -24834,6 +24834,7 @@
     this.bTypeValueList = false;
     this.bTypeNumber = false;
     this.bTypeAlarm = false;
+    this.bTypeString = false;
     this.bColLeft = false;
     this.bColCenter = false;
     this.bNameLeft = false;
@@ -25080,6 +25081,12 @@
             if (!bRet) { bRet = true; }
           }
         }
+        if (this.bTypeString) {
+          if (obj['type'] == "string")
+          {
+            if (!bRet) { bRet = true; }
+          }
+        }
         return bRet;
       }
     }
@@ -25133,6 +25140,7 @@
     if (this.bTypeValueList) return true;
     if (this.bTypeNumber) return true;
     if (this.bTypeAlarm) return true;
+    if (this.bTypeString) return true;
     return false; 
   },
     
@@ -25209,6 +25217,7 @@
     this.bTypeValueList = false;
     this.bTypeNumber = false;
     this.bTypeAlarm = false;
+    this.bTypeString = false;
     conInfo("Alle Filter wurden zurückgesetzt.");
   }
 };
@@ -25241,6 +25250,7 @@
       $("cbValueList").checked = fltObj.bTypeValueList;
       $("cbNumber").checked = fltObj.bTypeNumber;
       $("cbAlarm").checked = fltObj.bTypeAlarm;
+      $("cbString").checked = fltObj.bTypeString;
       break;
     case "btnFilterIfaceSub":
       $("cbSend").checked = fltObj.isFilterType(FIL_IFACE_S); 
@@ -25367,7 +25377,8 @@
       fltObj.bTypeLogic = $("cbLogic").checked;
       fltObj.bTypeValueList = $("cbValueList").checked;
       fltObj.bTypeNumber = $("cbNumber").checked;
-      fltObj.bTypeAlarm = $("cbAlarm").checked; 
+      fltObj.bTypeAlarm = $("cbAlarm").checked;
+      fltObj.bTypeString = $("cbString").checked;
       break;
     case "colPos":
       fltObj.bColLeft = $("cbColLeft").checked; 

/www/rega/pages/msg/sysVarsSelection.htm

--- sysVarsSelection.htm.orig
+++ sysVarsSelection.htm
@@ -117,6 +117,9 @@
                 <td>${lblAlarm}</td>
                 <td><input type="checkbox" id="cbAlarm" /></td>
               </tr>
+                <td>${lblString}</td>
+                <td><input type="checkbox" id="cbString" /></td>
+              </tr>
             </table>
             <div class='FilterSetButton' onclick='setAFilter(fltSVS, "vartypes");updateTable();$("btnFilterVarTypeSub").hide();'>${filterSet}</div>
             <div class='FilterSetButton' onclick="$('btnFilterVarTypeSub').hide();">${filterClose}</div>

/www/rega/pages/tabs/admin/systemvars.htm

--- systemvars.htm.orig
+++ systemvars.htm
@@ -101,6 +101,10 @@
             <td>${lblAlarm}</td>
             <td><input type="checkbox" id="cbAlarm" /></td>
           </tr>
+          <tr>
+            <td>${lblString}</td>
+            <td><input type="checkbox" id="cbString" /></td>
+          </tr>
         </table>
         <div class='FilterSetButton' onclick='setAFilter(fltSYV, "vartypes");updateTable();$("btnFilterVarTypeSub").hide();'>${filterSet}</div>
         <div class='FilterSetButton' onclick="$('btnFilterVarTypeSub').hide();">${filterClose}</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement-ideas New feature or change request 🏷️ WebUI This refs the WebUI component
Projects
Development

Successfully merging a pull request may close this issue.

4 participants