Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more things #287

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

more things #287

wants to merge 12 commits into from

Conversation

trinkey
Copy link
Member

@trinkey trinkey commented Dec 7, 2024

What does this do?

stuff

Issues completed:

Checklist for Reviewers

  • Version has been incremented (if appropriate) on the REAL_VERSION variable in backend/variables.py
  • Any new changes have been tested thoroughly (including api calls that wouldn't normally be possible using inspect element or the /api/docs page)
  • Any changes have been documented in CHANGELOG.md
  • Features that break easily have been tested (mostly viewing pages when not logged in)

trinkey
trinkey commented Dec 25, 2024
View reviewed changes
docs/running-the-server.md
Copy link
Member Author

@trinkey trinkey Dec 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's still an extra newline (L167)

smiggins/backend/variables.py
except ImportError:
try:
smtp_auth = {
"EMAIL_HOST":dotenv_dict["EMAIL_HOST"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there... should still be at least one space after the colon...

"EMAIL_HOST": dotenv_dict["EMAIL_HOST"]
...

smiggins/smiggins/settings.py
EMAIL_HOST_USER = dotenv_dict["EMAIL_HOST_USER"]
EMAIL_HOST_PASSWORD = dotenv_dict["EMAIL_HOST_PASSWORD"]
EMAIL_PORT = int(dotenv_dict["EMAIL_PORT"]) # type: ignore
EMAIL_USE_TLS = str.lower(str(dotenv_dict["EMAIL_USE_TLS"])) == "true"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str(dotenv_dict["EMAIL_USE_TLS"]).lower() == "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make post box css not suck add a button to delete read notifications compact ui
2 participants
@trinkey @Subroutine7901