Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event emitted when marker is recognized? #217

Closed
donmccurdy opened this issue Oct 9, 2017 · 10 comments
Closed

Event emitted when marker is recognized? #217

donmccurdy opened this issue Oct 9, 2017 · 10 comments

Comments

@donmccurdy
Copy link

donmccurdy commented Oct 9, 2017

Does the <a-marker/> primitive emit any events?

I'm responding to a question on aframe-extras, and not sure what if any events are fired, or if there's another way to trigger something happening when marker is scanned. Thanks!

@karneaud
Copy link

Does this still hold true? I'm seeing becameVisible and makerVisible....which one?

@donmccurdy
Copy link
Author

I see mentions of both in search, but no code that would emit them and no documentation about it. If someone has tested and they're working, that would be great.

@karneaud
Copy link

@donmccurdy actually there is a commit branch by @NikolayMihaylov that I tried out and it works perfectly so far using the emitevents="true" attribute. However it seems it is yet to be merged. perhaps a petition should be done to make this merge happen

@jeromeetienne
Copy link
Owner

events arent settled in the three.js API, and even less in the aframe api.

In fact i just looked https://github.com/jeromeetienne/AR.js/blob/master/aframe/src/component-anchor.js

and no event is emitted at all

@donmccurdy
Copy link
Author

Thanks @jeromeetienne! I think #303 would fix this, do you want a version of that PR that excludes the build files?

@peterlunglum
Copy link

@donmccurdy @jeromeetienne ,

Is the emitevents officially part of the main code base?

@donmccurdy
Copy link
Author

donmccurdy commented Apr 25, 2018

No, the official codebase does not emit any events when a marker is recognized. While the API may not be settled, I think some event or other will be important for many use cases and would recommend merging #303 or something like it.

@donmccurdy
Copy link
Author

Is an event emitted now, or is this not feasible?

@nicolocarpignoli
Copy link
Collaborator

this is merged #303 and works with (not with a-marker-camera apparently) :)

@donmccurdy
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants