fix(valid-describe): add check for empty arguments (#94)

Fixes #93
jest-community · Mar 13, 2018 · 80c9b33 · 80c9b33
1 parent fb54759
commit 80c9b33
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/rules/__tests__/valid-describe.test.js b/rules/__tests__/valid-describe.test.js
@@ -71,6 +71,16 @@ ruleTester.run('valid-describe', rule, {
         },
       ],
     },
+    {
+      code: 'describe()',
+      errors: [
+        {
+          message: 'Describe requires name and callback arguments',
+          line: 1,
+          column: 1,
+        },
+      ],
+    },
     {
       code: 'describe("foo", async () => {})',
       errors: [{ message: 'No async describe callback', line: 1, column: 17 }],

diff --git a/rules/valid-describe.js b/rules/valid-describe.js
@@ -37,6 +37,13 @@ module.exports = {
     return {
       CallExpression(node) {
         if (isDescribe(node)) {
+          if (node.arguments.length === 0) {
+            return context.report({
+              message: 'Describe requires name and callback arguments',
+              loc: node.loc,
+            });
+          }
+
           const name = node.arguments[0];
           const callbackFunction = node.arguments[1];
           if (!isString(name)) {