Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[valid-title] Feature: User-specified error message for jest/valid-title::mustMatch #688

Closed
ejfine opened this issue Oct 12, 2020 · 3 comments · Fixed by #913
Closed

[valid-title] Feature: User-specified error message for jest/valid-title::mustMatch #688

ejfine opened this issue Oct 12, 2020 · 3 comments · Fixed by #913

Comments

@ejfine
Copy link

ejfine commented Oct 12, 2020

The error message for jest/valid-title using mustMatch is not especially helpful to new users to a codebase that has that rule implemented. It just displays the regular expression.

Would you be open to a Pull Request to allow the eslint config for the rule to accept an [optional] plain text description that would be included in the error message to help make it clearer to people seeing the ESLint error what they did wrong and how to fix it?

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 17, 2020

I'm not against this - it would increase the complexity a bit, but no immediate blockers spring to mind so happy to explore this.

@G-Rath G-Rath self-assigned this Sep 25, 2021
@G-Rath G-Rath changed the title Feature: User-specified error message for jest/valid-title::mustMatch [valid-title] Feature: User-specified error message for jest/valid-title::mustMatch Sep 25, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 24.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 25.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants