Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Drop unmaintained dependency exit #13983

Closed
mcmxcdev opened this issue Mar 6, 2023 · 9 comments
Closed

[Feature]: Drop unmaintained dependency exit #13983

mcmxcdev opened this issue Mar 6, 2023 · 9 comments

Comments

@mcmxcdev
Copy link

mcmxcdev commented Mar 6, 2023

🚀 Feature Proposal

The package exit which @jest/core and @jest/reporters depend on has various issues according to: https://socket.dev/npm/package/exit

The last version published was 9 years ago and it has no license.

Motivation

Remove unmaintained dependencies and modernize codebase.

Example

No response

Pitch

@SimenB
Copy link
Member

SimenB commented Mar 6, 2023

What issues? If the module works, it being "unmaintained" is not an issue.

Missing license is more of an actual issue, but we've used exit for almost 5 years without anyone reporting it until now, so I'm inclined to say it's not proving to be an issue in practice.

@mcmxcdev
Copy link
Author

mcmxcdev commented Mar 6, 2023

My assumption was that the Node ecosystem would have progressed in the last 9 years so that exit is not needed anymore since there would be native functionality for it or the problem it was created for is not a problem anymore.

I guess it's fine to keep it since exit doesn't have any outdated dependencies on its own which would create potential incompatibilities.

@SimenB
Copy link
Member

SimenB commented Mar 6, 2023

Still an issue today. Workaround is slightly cleaner tho, so might be worth replacing: nodejs/node#6379.

@reporter123
Copy link

Its an MIT license just not in the package.json correctly. https://github.com/cowboy/node-exit/blob/master/LICENSE-MIT

@github-actions
Copy link

github-actions bot commented May 1, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 1, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@mcmxcdev
Copy link
Author

Might make sense to keep this issue around rather than have the bot autoclose it.

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants