-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JSDOM 4.0 #267
Comments
The fact that it no longer works in Node at all I s pretty disappointing and makes it a challenge to consider upgrading :( This means we're leaving a large chunk of users in the dust either way we go. I'd hope that jsdom (or some alternative) can come up with a pragmatic way of supporting both platforms. |
Yea, it is unfortunate, but this is exactly the reason why iojs was needed in the first place. I can respect their wish to force everyone to upgrade. Time will tell if they'll be successful or if the opposite will happen. I.e. that people are stuck on Node because libraries like jest can't or refuses to upgrade. |
I don't have a lot of....context...here, but it would be nice if it were possible for contextify to implement a compatibility layer that defers to |
I'll let that pun slide unnoticed. We could fork |
See also #221, which I guess now has more to consider. |
I compared the last compatible node 0.10 version of jsdom and the 4.0.0 (jsdom/jsdom@3.x...4.0.0), the only big incompatibility seems to be the use of the runtime/vm module. |
io.js recently announced they're moving back to Node so fragmentation shouldn't be so bad. Users who don't upgrade Node won't be able to run newer versions of jest but that's generally true anyway. I have a branch where I spent some time trying to get jest working with io.js 2.0 but I hit a wall with contextify/vm and didn't dig much deeper. https://github.com/ide/jest/tree/iojs |
@Sebmaster I looked into |
0.5 updates to jsdom 5.x so closing out. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Which no longer has a dependency on contextify which means that it doesn't cause random install breakage and it supports iojs!
The text was updated successfully, but these errors were encountered: