-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive snapshot mode instantly finishes (and reports updates that are not performed) #6485
Comments
Wonder if this is the same as #6431? |
Wow thanks for the repro @simonrepp, I'll take a look |
Yay, much appreciated @rickhanlonii ! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
💥 Regression Report
Hi!
Since my jest update from 22.4.3 to 23.1.0, interactive snapshot mode stopped working for me in one specific project. (I tried to reproduce the issue in a barebones project setup with just jest and a single test and there it did not occur).
Basically this is where I start off, a single failing spec (which can be any, or many, observed this at least three times):
When I press
i
to enter interactive mode I immediately (without any interaction) see this:(Although it says that snapshots were updated nothing happens in the background though)
Then I press enter and I am back at the same state as in the first screenshot seen above. Repeating the process yields the same result again.
Last working version
Worked up to version: 22.4.3
Stopped working in version: 23.1.0
To Reproduce
As stated I cannot reproduce this problem in a minimal setup, so I created a branch off my project with a single failing test that demonstrates the problem (branch is here: https://github.com/eno-lang/enojs/tree/jest-interactive-snapshot-updates-issue).
(Note regarding
npm i
: jest is the only dependency being used/installed)This should leave you at where I start off in the description above, then press
i
and the issue should surface by skipping interactive mode.To verify it's in fact a regression I also ran this:
npm i jest@22.4.3 npm test
With this, the following steps work, interactive mode is indeed interactive there. :)
System info
System: OS: Linux 4.13 Ubuntu 17.10 (Artful Aardvark) CPU: x64 Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz Binaries: Node: 10.4.1 - /usr/bin/node npm: 6.1.0 - /usr/bin/npm npmPackages: jest: ^23.1.0 => 23.1.0
Thanks so much for looking into it, jest is fantastic, much obliged!
The text was updated successfully, but these errors were encountered: