find tests when path includes folder starting with a period #7267

JohnAlbin · 2018-10-25T08:21:29Z

🐛 Bug Report

This is a regression of the bug reported in #3111 that was fixed in #3006 and broke again sometime in the v23 branch.

When a test is inside a folder that has a name starting with period, ., they are ignored by testMatch and by testRegex. It's even more obscure if the entire project is checked out below a dot-folder, in which case all tests are ignored.

To Reproduce

Given the following directory listing:

~/projects/jestbug/.app/__tests__/atest.js
~/projects/jestbug/.app/atest.test.js
~/projects/jestbug/app/atest.test.js
~/projects/jestbug/app/.subfolder/__tests__/atest.js
~/projects/jestbug/app/.subfolder/atest.test.js
~/projects/jestbug/app/__tests__/atest.js
~/projects/jestbug/atest.test.js

Using the following package.json:

{
  "name": "jestbug",
  "devDependencies": {
    "jest": "^23.6.0"
  }
}

None of the tests in a folder staring with . are found:

$ rm -rf node_modules
$ npm install
$ npx jest --listTests --no-cache
~/projects/jestbug/atest.test.js
~/projects/jestbug/app/atest.test.js
~/projects/jestbug/app/__tests__/atest.js

Using the following package.json:

{
  "name": "jestbug",
  "devDependencies": {
    "jest": "^23.6.0"
  },
  "jest": {
    "testRegex": "(/__tests__/.*|(\\.|/)(test|spec))\\.jsx?$"
  }
}

None of the tests in a folder staring with . are found:

$ rm -rf node_modules
$ npm install
$ npx jest --listTests --no-cache
~/projects/jestbug/atest.test.js
~/projects/jestbug/app/atest.test.js
~/projects/jestbug/app/__tests__/atest.js

Expected behavior

Using the following package.json:

{
  "name": "jestbug",
  "devDependencies": {
    "jest": "^22.4.4"
  }
}

$ rm -rf node_modules
$ npm install
$ npx jest --listTests --no-cache
~/projects/jestbug/app/atest.test.js
~/projects/jestbug/.app/atest.test.js
~/projects/jestbug/app/.subfolder/atest.test.js
~/projects/jestbug/atest.test.js
~/projects/jestbug/app/.subfolder/__tests__/atest.js
~/projects/jestbug/app/__tests__/atest.js
~/projects/jestbug/.app/__tests__/atest.js

Using the following package.json:

{
  "name": "jestbug",
  "devDependencies": {
    "jest": "^22.4.4"
  },
  "jest": {
    "testRegex": "(/__tests__/.*|(\\.|/)(test|spec))\\.jsx?$"
  }
}

$ rm -rf node_modules
$ npm install
$ npx jest --listTests --no-cache
~/projects/jestbug/app/atest.test.js
~/projects/jestbug/.app/atest.test.js
~/projects/jestbug/app/.subfolder/atest.test.js
~/projects/jestbug/atest.test.js
~/projects/jestbug/app/.subfolder/__tests__/atest.js
~/projects/jestbug/app/__tests__/atest.js
~/projects/jestbug/.app/__tests__/atest.js

Link to repl or repo (highly encouraged)

Note that repl.it currently uses Jest v22 and I can't figure out how to make it run under v23.

But here's the demo link where the bug is NOT present because v22 is not broken. https://repl.it/@John_AlbinAlbin/CarpalSoulfulDirectories

Run `npx envinfo --preset jest`

  System:
    OS: macOS 10.14
    CPU: x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
    Yarn: 1.10.1 - ~/.yarn/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
  npmPackages:
    jest: ^23.6.0 => 23.6.0

The text was updated successfully, but these errors were encountered:

SimenB · 2018-10-25T08:40:25Z

~~Could you set up a quick repository we can pull down and see the error in?~~ I copied out your repl to my local machine and can reproduce

The test I said was failing for me in #3111 was actually fixed by me restarting watchman locally...

thymikee · 2018-10-25T08:43:51Z

You can restart watchman by doing watchman watch-del $PWD or watchman watch-del-all (will remove all other projects crawl cache, if they use watchamn).

SimenB · 2018-10-25T09:08:27Z

I can confirm that killing watchman seems to fix this.

Is it a bug in watchman?

JohnAlbin · 2018-10-25T11:32:34Z

I've created https://github.com/JohnAlbin/jest-bug-7267 with the example repo.

I tried watchman watch-del-all and it had no effect on the failure of npx jest --no-cache --listTests to find all 7 tests; it only finds 3 tests.

SimenB · 2018-10-25T11:48:58Z

With your repo:

SimenB · 2018-10-25T11:52:56Z

What happens if you do jest --listTests --no-watchman?

JohnAlbin · 2018-10-25T12:15:30Z

npx jest --listTests --no-cache only finds 3 tests (as stated before)

But npx jest --listTests --no-watchman --no-cache finds all 7 tests!

FYI, Jest's cache was giving me inconsistent results; if I installed Jest v22, ran the tests, and then re-installed v23, the tests would all be found until I used the --no-cache option.

ewolfe · 2018-10-25T20:33:03Z

I'm not sure if this is related, but I'm experiencing an issue when running jest via yarn.

Given:

"scripts": {
  "jest": "jest .storybook"
}

Then yarn jest fails, while npm run jest runs just fine.

No tests found
In /Users/ewolfe/Projects/<myProject>
  2020 files checked.
  testMatch: **/__tests__/**/*.js?(x),**/?(*.)+(spec|test).js?(x) - 245 matches
  testPathIgnorePatterns: /node_modules/ - 2020 matches
Pattern: .storybook - 0 matches

Update: this is probably just user error on my end, a co-worker is running my code and not having any issues.

JohnAlbin · 2018-10-26T13:44:41Z

this is probably just user error on my end

This bug made me question my sanity at first too.

a co-worker is running my code and not having any issues.

FYI, because of the Jest cache issues, that's exactly what was happening to my team. My co-worker saw the bug and I didn't. Then finally I did see the bug, but after a day it disappeared. Then reappeared. However, we always used Yarn (not npm). AND, the tests that were being skipped were ones that we put in our .storybook folder.

joanasmramos · 2018-11-30T10:54:31Z

Hello, me and two other students are trying to fix this issue for a course in college. However, it's our first time working with jest (and any open source project really) so we are not so sure how to work this. We've done an UML components diagram for the whole system but still don't understand the flow of the program and are having a hard time finding the files directly and indirectly involved in this issue. Another problem we are having is in replicating and possibly testing our solution. If you could please give us some guidelines we would be very grateful!

rickhanlonii · 2018-11-30T11:58:32Z

@joanasmramos thats so cool! I'd love to see the UML diagram at some point :D

This video may be helpful for you for understanding how the jest architecture works

That being said, this may not be a good first issue to work on because it sounds like the issue may not be in Jest but in a tool we use called Watchman. You can search our issues with the Good First Issue label to find issues good for people intro'ing to the code base 👌

github-actions · 2022-02-25T13:02:52Z

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions · 2022-03-27T13:03:22Z

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

github-actions · 2022-05-02T00:08:06Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

heyimalex mentioned this issue Sep 8, 2019

react-scripts test not working with hidden directories (prefixed with .) facebook/create-react-app#7660

Open

lencioni mentioned this issue May 19, 2020

Haste map is sometimes missing dotfiles #10063

Closed

github-actions bot added the Stale label Feb 25, 2022

github-actions bot closed this as completed Mar 27, 2022

github-actions bot locked as resolved and limited conversation to collaborators May 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

find tests when path includes folder starting with a period #7267

find tests when path includes folder starting with a period #7267

JohnAlbin commented Oct 25, 2018

SimenB commented Oct 25, 2018 •

edited

Loading

thymikee commented Oct 25, 2018

SimenB commented Oct 25, 2018

JohnAlbin commented Oct 25, 2018

SimenB commented Oct 25, 2018

SimenB commented Oct 25, 2018 •

edited

Loading

JohnAlbin commented Oct 25, 2018 •

edited

Loading

ewolfe commented Oct 25, 2018 •

edited

Loading

JohnAlbin commented Oct 26, 2018 •

edited

Loading

joanasmramos commented Nov 30, 2018

rickhanlonii commented Nov 30, 2018

github-actions bot commented Feb 25, 2022

github-actions bot commented Mar 27, 2022

github-actions bot commented May 2, 2022

find tests when path includes folder starting with a period #7267

find tests when path includes folder starting with a period #7267

Comments

JohnAlbin commented Oct 25, 2018

🐛 Bug Report

To Reproduce

Expected behavior

Link to repl or repo (highly encouraged)

Run npx envinfo --preset jest

SimenB commented Oct 25, 2018 • edited Loading

thymikee commented Oct 25, 2018

SimenB commented Oct 25, 2018

JohnAlbin commented Oct 25, 2018

SimenB commented Oct 25, 2018

SimenB commented Oct 25, 2018 • edited Loading

JohnAlbin commented Oct 25, 2018 • edited Loading

ewolfe commented Oct 25, 2018 • edited Loading

JohnAlbin commented Oct 26, 2018 • edited Loading

joanasmramos commented Nov 30, 2018

rickhanlonii commented Nov 30, 2018

github-actions bot commented Feb 25, 2022

github-actions bot commented Mar 27, 2022

github-actions bot commented May 2, 2022

Run `npx envinfo --preset jest`

SimenB commented Oct 25, 2018 •

edited

Loading

SimenB commented Oct 25, 2018 •

edited

Loading

JohnAlbin commented Oct 25, 2018 •

edited

Loading

ewolfe commented Oct 25, 2018 •

edited

Loading

JohnAlbin commented Oct 26, 2018 •

edited

Loading