Fix/Downgrade ruby to work on heroku #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusMava
force-pushed
the
Fix/Update-ruby-to-work-on-heroku
branch
from
39b661b to
3d80469
Compare
itsmeurbi
requested changes
Jan 26, 2022
| @@ -36,7 +36,7 @@ class CommentsControllerTest < ActionDispatch::IntegrationTest | |||
| test 'user should be able to edit their own comments' do | |||
| user = create(:user) | |||
| curiosity = create(:curiosity_card) | |||
| comment = create(:comment, curiosity_card: curiosity, user: ) | |||
| comment = create(:comment, curiosity_card: curiosity, user: user) | |||
There was a problem hiding this comment.
This changes has nothing to do with ruby version downgrade hehe
There was a problem hiding this comment.
actually, we need it because it's a new release from ruby 3.1.0 https://www.ruby-lang.org/en/news/2021/11/09/ruby-3-1-0-preview1-released/ hehe and my test was broken because of it :c hehe
There was a problem hiding this comment.
Holy smokes!
Using user: does actually looks for a user var. That's crazy dude haha
itsmeurbi
approved these changes
Jan 26, 2022
luisAzcuaga
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrade ruby from 3.1 to 3.0.3 because it was an error with prawn gem to deploy on heroku
here are the issues:
prawnpdf/prawn#1195
prawnpdf/prawn#1235