Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Customize vault-helper download URL #393

Closed
Wiston999 opened this issue Jul 31, 2018 · 3 comments · Fixed by #619 · May be fixed by #395
Closed

Customize vault-helper download URL #393

Wiston999 opened this issue Jul 31, 2018 · 3 comments · Fixed by #619 · May be fixed by #395
Assignees
@simonswine
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.6

Comments

@Wiston999
Copy link

Wiston999 commented Jul 31, 2018 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What you expected to happen:
It would be useful to allow the override of the vault-helper download url in vault_client module so it can be downloaded from local mirrors instead of github.com
@jetstack-bot jetstack-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2018
@Wiston999 Wiston999 mentioned this issue Aug 1, 2018
Open
@simonswine simonswine added this to the release-0.5 milestone Aug 3, 2018
@simonswine
Copy link
Contributor

/assign @JoshVanL

@JoshVanL JoshVanL mentioned this issue Aug 8, 2018
Closed
@JoshVanL JoshVanL mentioned this issue Nov 12, 2018
Merged
@simonswine simonswine added the kind/bug Categorizes issue or PR as related to a bug. label Nov 14, 2018
@JoshVanL
Copy link
Contributor

@simonswine You've moved the open PR to this to 0.6 #619
Guess we should move this to 0.6 too?
/assign @simonswine
/unassign

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Nov 19, 2018
@simonswine
Copy link
Contributor

Yes good point we should

@simonswine simonswine modified the milestones: release-0.5, release-0.6 Nov 19, 2018
@simonswine simonswine removed the kind/bug Categorizes issue or PR as related to a bug. label Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@simonswine simonswine

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.6
4 participants
@simonswine @Wiston999 @JoshVanL @jetstack-bot