diff --git a/jetty-bom/pom.xml b/jetty-bom/pom.xml index dd196cd069a3..f328841c9809 100644 --- a/jetty-bom/pom.xml +++ b/jetty-bom/pom.xml @@ -379,6 +379,16 @@ websocket-core 10.0.0-SNAPSHOT + + org.eclipse.jetty.websocket + websocket-util + 10.0.0-SNAPSHOT + + + org.eclipse.jetty.websocket + websocket-util-server + 10.0.0-SNAPSHOT + org.eclipse.jetty jetty-xml diff --git a/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java b/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java index 1bc633479fbe..4b8869c575be 100644 --- a/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java +++ b/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java @@ -149,6 +149,7 @@ public static List + + org.eclipse.jetty.websocket + websocket-util-server + ${project.version} + org.slf4j slf4j-api diff --git a/jetty-websocket/websocket-javax-server/src/main/config/modules/websocket-javax.mod b/jetty-websocket/websocket-javax-server/src/main/config/modules/websocket-javax.mod index 0a0941e921e7..53395ec65174 100644 --- a/jetty-websocket/websocket-javax-server/src/main/config/modules/websocket-javax.mod +++ b/jetty-websocket/websocket-javax-server/src/main/config/modules/websocket-javax.mod @@ -13,6 +13,7 @@ annotations [lib] lib/websocket/websocket-core-${jetty.version}.jar lib/websocket/websocket-util-${jetty.version}.jar +lib/websocket/websocket-util-server${jetty.version}.jar lib/websocket/jetty-javax-websocket-api-1.1.2.jar lib/websocket/websocket-javax-client-${jetty.version}.jar lib/websocket/websocket-javax-common-${jetty.version}.jar diff --git a/jetty-websocket/websocket-javax-server/src/main/java/module-info.java b/jetty-websocket/websocket-javax-server/src/main/java/module-info.java index 1c809f98d6c2..af5c88bbdd4c 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/module-info.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/module-info.java @@ -31,6 +31,7 @@ requires transitive org.eclipse.jetty.webapp; requires transitive org.eclipse.jetty.websocket.javax.client; requires org.eclipse.jetty.websocket.javax.common; + requires org.eclipse.jetty.websocket.util.server; requires org.slf4j; provides ServletContainerInitializer with JavaxWebSocketServletContainerInitializer; diff --git a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/config/JavaxWebSocketServletContainerInitializer.java b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/config/JavaxWebSocketServletContainerInitializer.java index a2404d16e9f3..87739c6a4349 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/config/JavaxWebSocketServletContainerInitializer.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/config/JavaxWebSocketServletContainerInitializer.java @@ -38,8 +38,8 @@ import org.eclipse.jetty.util.thread.ThreadClassLoaderScope; import org.eclipse.jetty.websocket.core.WebSocketComponents; import org.eclipse.jetty.websocket.javax.server.internal.JavaxWebSocketServerContainer; -import org.eclipse.jetty.websocket.util.server.WebSocketMapping; import org.eclipse.jetty.websocket.util.server.WebSocketUpgradeFilter; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxServerUpgradeRequest.java b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxServerUpgradeRequest.java index 0760c4fac4cc..160ba56a1120 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxServerUpgradeRequest.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxServerUpgradeRequest.java @@ -22,7 +22,7 @@ import java.security.Principal; import org.eclipse.jetty.websocket.javax.common.UpgradeRequest; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; public class JavaxServerUpgradeRequest implements UpgradeRequest { diff --git a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketCreator.java b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketCreator.java index e5ab6225e256..e66f98c19ede 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketCreator.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketCreator.java @@ -37,9 +37,9 @@ import org.eclipse.jetty.websocket.javax.common.JavaxWebSocketContainer; import org.eclipse.jetty.websocket.javax.common.JavaxWebSocketExtension; import org.eclipse.jetty.websocket.javax.common.ServerEndpointConfigWrapper; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeResponse; -import org.eclipse.jetty.websocket.util.server.WebSocketCreator; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeResponse; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketCreator; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java index fb2ecbb9e5e9..35a5ba4a86c6 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java @@ -39,7 +39,7 @@ import org.eclipse.jetty.websocket.core.exception.WebSocketException; import org.eclipse.jetty.websocket.javax.client.internal.JavaxWebSocketClientContainer; import org.eclipse.jetty.websocket.javax.server.config.JavaxWebSocketServletContainerInitializer; -import org.eclipse.jetty.websocket.util.server.WebSocketMapping; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerFrameHandlerFactory.java b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerFrameHandlerFactory.java index 52dbab393fda..bb81bbc3704d 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerFrameHandlerFactory.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerFrameHandlerFactory.java @@ -27,9 +27,9 @@ import org.eclipse.jetty.websocket.javax.client.internal.JavaxWebSocketClientFrameHandlerFactory; import org.eclipse.jetty.websocket.javax.common.JavaxWebSocketContainer; import org.eclipse.jetty.websocket.javax.common.JavaxWebSocketFrameHandlerMetadata; -import org.eclipse.jetty.websocket.util.server.FrameHandlerFactory; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeResponse; +import org.eclipse.jetty.websocket.util.server.internal.FrameHandlerFactory; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeResponse; public class JavaxWebSocketServerFrameHandlerFactory extends JavaxWebSocketClientFrameHandlerFactory implements FrameHandlerFactory { diff --git a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeRequest.java b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeRequest.java index 8cd64bb62998..dbb8e1f1fb37 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeRequest.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeRequest.java @@ -25,7 +25,7 @@ import javax.websocket.server.HandshakeRequest; import org.eclipse.jetty.http.pathmap.PathSpec; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; public class JsrHandshakeRequest implements HandshakeRequest { diff --git a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeResponse.java b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeResponse.java index 8a3e268313c4..80ec6a7502b5 100644 --- a/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeResponse.java +++ b/jetty-websocket/websocket-javax-server/src/main/java/org/eclipse/jetty/websocket/javax/server/internal/JsrHandshakeResponse.java @@ -23,7 +23,7 @@ import java.util.Map; import javax.websocket.HandshakeResponse; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeResponse; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeResponse; public class JsrHandshakeResponse implements HandshakeResponse { diff --git a/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/client/MessageReceivingTest.java b/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/client/MessageReceivingTest.java index 5161bf2c05eb..9699f2a3bc02 100644 --- a/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/client/MessageReceivingTest.java +++ b/jetty-websocket/websocket-javax-tests/src/test/java/org/eclipse/jetty/websocket/javax/tests/client/MessageReceivingTest.java @@ -47,7 +47,7 @@ import org.eclipse.jetty.websocket.core.server.Negotiation; import org.eclipse.jetty.websocket.javax.tests.CoreServer; import org.eclipse.jetty.websocket.javax.tests.DataUtils; -import org.eclipse.jetty.websocket.util.TextUtil; +import org.eclipse.jetty.websocket.util.TextUtils; import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeAll; @@ -328,7 +328,7 @@ public void onText(String wholeMessage, Callback callback) { if (LOG.isDebugEnabled()) { - LOG.debug("{}.onWholeText({})", EchoWholeMessageFrameHandler.class.getSimpleName(), TextUtil.hint(wholeMessage)); + LOG.debug("{}.onWholeText({})", EchoWholeMessageFrameHandler.class.getSimpleName(), TextUtils.hint(wholeMessage)); } sendText(wholeMessage, callback, false); diff --git a/jetty-websocket/websocket-jetty-common/src/test/java/org/eclipse/jetty/websocket/common/EndPoints.java b/jetty-websocket/websocket-jetty-common/src/test/java/org/eclipse/jetty/websocket/common/EndPoints.java index 373e0dd7ccc5..4ec9847e0af0 100644 --- a/jetty-websocket/websocket-jetty-common/src/test/java/org/eclipse/jetty/websocket/common/EndPoints.java +++ b/jetty-websocket/websocket-jetty-common/src/test/java/org/eclipse/jetty/websocket/common/EndPoints.java @@ -38,7 +38,7 @@ import org.eclipse.jetty.websocket.api.annotations.OnWebSocketMessage; import org.eclipse.jetty.websocket.api.annotations.WebSocket; import org.eclipse.jetty.websocket.core.CloseStatus; -import org.eclipse.jetty.websocket.util.TextUtil; +import org.eclipse.jetty.websocket.util.TextUtils; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.notNullValue; @@ -62,7 +62,7 @@ public void onWebSocketBinary(byte[] payload, int offset, int len) @Override public void onWebSocketClose(int statusCode, String reason) { - events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtil.quote(reason)); + events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtils.quote(reason)); } @Override @@ -74,13 +74,13 @@ public void onWebSocketConnect(Session session) @Override public void onWebSocketError(Throwable cause) { - events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtil.quote(cause.getMessage())); + events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtils.quote(cause.getMessage())); } @Override public void onWebSocketText(String message) { - events.add("onWebSocketText(%s)", TextUtil.quote(message)); + events.add("onWebSocketText(%s)", TextUtils.quote(message)); } } @@ -91,7 +91,7 @@ public static class ListenerFrameSocket implements WebSocketFrameListener @Override public void onWebSocketClose(int statusCode, String reason) { - events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtil.quote(reason)); + events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtils.quote(reason)); } @Override @@ -103,7 +103,7 @@ public void onWebSocketConnect(Session session) @Override public void onWebSocketError(Throwable cause) { - events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtil.quote(cause.getMessage())); + events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtils.quote(cause.getMessage())); } @Override @@ -120,7 +120,7 @@ public static class ListenerPartialSocket implements WebSocketPartialListener @Override public void onWebSocketClose(int statusCode, String reason) { - events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtil.quote(reason)); + events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtils.quote(reason)); } @Override @@ -132,13 +132,13 @@ public void onWebSocketConnect(Session session) @Override public void onWebSocketError(Throwable cause) { - events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtil.quote(cause.getMessage())); + events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtils.quote(cause.getMessage())); } @Override public void onWebSocketPartialText(String payload, boolean fin) { - events.add("onWebSocketPartialText(%s, %b)", TextUtil.quote(payload), fin); + events.add("onWebSocketPartialText(%s, %b)", TextUtils.quote(payload), fin); } @Override @@ -155,7 +155,7 @@ public static class ListenerPingPongSocket implements WebSocketPingPongListener @Override public void onWebSocketClose(int statusCode, String reason) { - events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtil.quote(reason)); + events.add("onWebSocketClose(%s, %s)", CloseStatus.codeString(statusCode), TextUtils.quote(reason)); } @Override @@ -167,7 +167,7 @@ public void onWebSocketConnect(Session session) @Override public void onWebSocketError(Throwable cause) { - events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtil.quote(cause.getMessage())); + events.add("onWebSocketError((%s) %s)", cause.getClass().getSimpleName(), TextUtils.quote(cause.getMessage())); } @Override @@ -228,7 +228,7 @@ public void onBinary(byte[] payload, int offset, int length) @OnWebSocketClose public void onClose(int statusCode, String reason) { - events.add("onClose(%d, %s)", statusCode, TextUtil.quote(reason)); + events.add("onClose(%d, %s)", statusCode, TextUtils.quote(reason)); } @OnWebSocketConnect @@ -253,7 +253,7 @@ public void onBinary(InputStream stream) @OnWebSocketClose public void onClose(int statusCode, String reason) { - events.add("onClose(%d, %s)", statusCode, TextUtil.quote(reason)); + events.add("onClose(%d, %s)", statusCode, TextUtils.quote(reason)); } @OnWebSocketConnect @@ -271,7 +271,7 @@ public static class AnnotatedTextSocket @OnWebSocketClose public void onClose(int statusCode, String reason) { - events.add("onClose(%d, %s)", statusCode, TextUtil.quote(reason)); + events.add("onClose(%d, %s)", statusCode, TextUtils.quote(reason)); } @OnWebSocketConnect @@ -289,7 +289,7 @@ public void onError(Throwable cause) @OnWebSocketMessage public void onText(String message) { - events.add("onText(%s)", TextUtil.quote(message)); + events.add("onText(%s)", TextUtils.quote(message)); } } @@ -301,7 +301,7 @@ public static class AnnotatedTextStreamSocket @OnWebSocketClose public void onClose(int statusCode, String reason) { - events.add("onClose(%d, %s)", statusCode, TextUtil.quote(reason)); + events.add("onClose(%d, %s)", statusCode, TextUtils.quote(reason)); } @OnWebSocketConnect diff --git a/jetty-websocket/websocket-jetty-server/pom.xml b/jetty-websocket/websocket-jetty-server/pom.xml index a4454dae0dc9..ade9576c6e75 100644 --- a/jetty-websocket/websocket-jetty-server/pom.xml +++ b/jetty-websocket/websocket-jetty-server/pom.xml @@ -46,6 +46,11 @@ websocket-jetty-common ${project.version} + + org.eclipse.jetty.websocket + websocket-util-server + ${project.version} + org.eclipse.jetty.toolchain jetty-servlet-api diff --git a/jetty-websocket/websocket-jetty-server/src/main/config/modules/websocket-jetty.mod b/jetty-websocket/websocket-jetty-server/src/main/config/modules/websocket-jetty.mod index c0e09e50fc51..93f767e44ee8 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/config/modules/websocket-jetty.mod +++ b/jetty-websocket/websocket-jetty-server/src/main/config/modules/websocket-jetty.mod @@ -13,6 +13,7 @@ annotations [lib] lib/websocket/websocket-core-${jetty.version}.jar lib/websocket/websocket-util-${jetty.version}.jar +lib/websocket/websocket-util-server${jetty.version}.jar lib/websocket/websocket-jetty-api-${jetty.version}.jar lib/websocket/websocket-jetty-common-${jetty.version}.jar lib/websocket/websocket-jetty-server-${jetty.version}.jar diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/module-info.java b/jetty-websocket/websocket-jetty-server/src/main/java/module-info.java index 78dff18d6e1b..6156e8d5a307 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/module-info.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/module-info.java @@ -29,9 +29,10 @@ requires jetty.servlet.api; requires org.eclipse.jetty.websocket.jetty.common; + requires org.eclipse.jetty.websocket.util.server; + requires org.slf4j; requires transitive org.eclipse.jetty.webapp; requires transitive org.eclipse.jetty.websocket.jetty.api; - requires org.slf4j; // Only required if using JMX. requires static org.eclipse.jetty.jmx; diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeRequest.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeRequest.java index 52868f985272..13e0b330d610 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeRequest.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeRequest.java @@ -36,7 +36,7 @@ import org.eclipse.jetty.websocket.api.extensions.ExtensionConfig; import org.eclipse.jetty.websocket.common.JettyExtensionConfig; import org.eclipse.jetty.websocket.core.server.Negotiation; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; public class JettyServerUpgradeRequest { diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeResponse.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeResponse.java index f6ddcf4faf1e..01e015302ed9 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeResponse.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyServerUpgradeResponse.java @@ -26,7 +26,7 @@ import org.eclipse.jetty.websocket.api.extensions.ExtensionConfig; import org.eclipse.jetty.websocket.common.JettyExtensionConfig; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeResponse; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeResponse; public class JettyServerUpgradeResponse { diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServerContainer.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServerContainer.java index 788ed7f808cf..06a614efec25 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServerContainer.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServerContainer.java @@ -41,8 +41,8 @@ import org.eclipse.jetty.websocket.core.exception.WebSocketException; import org.eclipse.jetty.websocket.server.config.JettyWebSocketServletContainerInitializer; import org.eclipse.jetty.websocket.server.internal.JettyServerFrameHandlerFactory; -import org.eclipse.jetty.websocket.util.server.FrameHandlerFactory; -import org.eclipse.jetty.websocket.util.server.WebSocketMapping; +import org.eclipse.jetty.websocket.util.server.internal.FrameHandlerFactory; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServlet.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServlet.java index cac83a3de737..448694577c50 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServlet.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServlet.java @@ -32,12 +32,12 @@ import org.eclipse.jetty.websocket.core.Configuration; import org.eclipse.jetty.websocket.core.WebSocketComponents; import org.eclipse.jetty.websocket.server.internal.JettyServerFrameHandlerFactory; -import org.eclipse.jetty.websocket.util.server.FrameHandlerFactory; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeResponse; -import org.eclipse.jetty.websocket.util.server.WebSocketCreator; -import org.eclipse.jetty.websocket.util.server.WebSocketMapping; import org.eclipse.jetty.websocket.util.server.WebSocketUpgradeFilter; +import org.eclipse.jetty.websocket.util.server.internal.FrameHandlerFactory; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeResponse; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketCreator; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java index 405e957f8d72..43b65eafd163 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/config/JettyWebSocketServletContainerInitializer.java @@ -27,8 +27,8 @@ import org.eclipse.jetty.servlet.listener.ContainerInitializer; import org.eclipse.jetty.websocket.core.WebSocketComponents; import org.eclipse.jetty.websocket.server.JettyWebSocketServerContainer; -import org.eclipse.jetty.websocket.util.server.WebSocketMapping; import org.eclipse.jetty.websocket.util.server.WebSocketUpgradeFilter; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/JettyServerFrameHandlerFactory.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/JettyServerFrameHandlerFactory.java index 19abc5c08bc8..ce4d9989c648 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/JettyServerFrameHandlerFactory.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/JettyServerFrameHandlerFactory.java @@ -27,9 +27,9 @@ import org.eclipse.jetty.websocket.common.JettyWebSocketFrameHandler; import org.eclipse.jetty.websocket.common.JettyWebSocketFrameHandlerFactory; import org.eclipse.jetty.websocket.core.FrameHandler; -import org.eclipse.jetty.websocket.util.server.FrameHandlerFactory; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeResponse; +import org.eclipse.jetty.websocket.util.server.internal.FrameHandlerFactory; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeResponse; public class JettyServerFrameHandlerFactory extends JettyWebSocketFrameHandlerFactory diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeRequestAdapter.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeRequestAdapter.java index ade89044129a..bddf712cf152 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeRequestAdapter.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeRequestAdapter.java @@ -28,7 +28,7 @@ import org.eclipse.jetty.websocket.api.UpgradeRequest; import org.eclipse.jetty.websocket.api.extensions.ExtensionConfig; import org.eclipse.jetty.websocket.common.JettyExtensionConfig; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeRequest; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeRequest; public class UpgradeRequestAdapter implements UpgradeRequest { diff --git a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeResponseAdapter.java b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeResponseAdapter.java index e957b63697e3..586d78e91c1f 100644 --- a/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeResponseAdapter.java +++ b/jetty-websocket/websocket-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/internal/UpgradeResponseAdapter.java @@ -27,7 +27,7 @@ import org.eclipse.jetty.websocket.api.UpgradeResponse; import org.eclipse.jetty.websocket.api.extensions.ExtensionConfig; import org.eclipse.jetty.websocket.common.JettyExtensionConfig; -import org.eclipse.jetty.websocket.util.server.ServletUpgradeResponse; +import org.eclipse.jetty.websocket.util.server.internal.ServletUpgradeResponse; public class UpgradeResponseAdapter implements UpgradeResponse { diff --git a/jetty-websocket/websocket-jetty-tests/src/test/java/org/eclipse/jetty/websocket/tests/server/PartialListenerTest.java b/jetty-websocket/websocket-jetty-tests/src/test/java/org/eclipse/jetty/websocket/tests/server/PartialListenerTest.java index 1c2804d59f49..117d89161f4c 100644 --- a/jetty-websocket/websocket-jetty-tests/src/test/java/org/eclipse/jetty/websocket/tests/server/PartialListenerTest.java +++ b/jetty-websocket/websocket-jetty-tests/src/test/java/org/eclipse/jetty/websocket/tests/server/PartialListenerTest.java @@ -47,7 +47,7 @@ import org.eclipse.jetty.websocket.server.JettyWebSocketServletFactory; import org.eclipse.jetty.websocket.server.config.JettyWebSocketServletContainerInitializer; import org.eclipse.jetty.websocket.tests.CloseTrackingEndpoint; -import org.eclipse.jetty.websocket.util.TextUtil; +import org.eclipse.jetty.websocket.util.TextUtils; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; @@ -297,7 +297,7 @@ public void onWebSocketPartialBinary(ByteBuffer payload, boolean fin) @Override public void onWebSocketPartialText(String payload, boolean fin) { - partialEvents.offer(String.format("TEXT[payload=%s, fin=%b]", TextUtil.maxStringLength(30, payload), fin)); + partialEvents.offer(String.format("TEXT[payload=%s, fin=%b]", TextUtils.maxStringLength(30, payload), fin)); } } } diff --git a/jetty-websocket/websocket-util-server/pom.xml b/jetty-websocket/websocket-util-server/pom.xml new file mode 100644 index 000000000000..f1e01777775f --- /dev/null +++ b/jetty-websocket/websocket-util-server/pom.xml @@ -0,0 +1,75 @@ + + + + org.eclipse.jetty.websocket + websocket-parent + 10.0.0-SNAPSHOT + + + 4.0.0 + websocket-util-server + Jetty :: Websocket :: org.eclipse.jetty.websocket :: Util-Server + + + ${project.groupId}.util.server + + + + + + org.apache.maven.plugins + maven-enforcer-plugin + + + ban-java-servlet-api + + enforce + + + + + + javax.servlet + servletapi + org.eclipse.jetty.orbit:javax.servlet + org.mortbay.jetty:servlet-api + jetty:servlet-api + jetty-servlet-api + + + + + + + + + + + + + org.eclipse.jetty.websocket + websocket-core + ${project.version} + + + org.eclipse.jetty + jetty-servlet + ${project.version} + provided + + + org.slf4j + slf4j-api + + + org.eclipse.jetty + jetty-slf4j-impl + test + + + org.eclipse.jetty.toolchain + jetty-test-helper + test + + + diff --git a/jetty-websocket/websocket-util-server/src/main/java/module-info.java b/jetty-websocket/websocket-util-server/src/main/java/module-info.java new file mode 100644 index 000000000000..ae57cc588942 --- /dev/null +++ b/jetty-websocket/websocket-util-server/src/main/java/module-info.java @@ -0,0 +1,27 @@ +// +// ======================================================================== +// Copyright (c) 1995-2020 Mort Bay Consulting Pty Ltd and others. +// +// This program and the accompanying materials are made available under +// the terms of the Eclipse Public License 2.0 which is available at +// https://www.eclipse.org/legal/epl-2.0 +// +// This Source Code may also be made available under the following +// Secondary Licenses when the conditions for such availability set +// forth in the Eclipse Public License, v. 2.0 are satisfied: +// the Apache License v2.0 which is available at +// https://www.apache.org/licenses/LICENSE-2.0 +// +// SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 +// ======================================================================== +// + +module org.eclipse.jetty.websocket.util.server +{ + exports org.eclipse.jetty.websocket.util.server; + exports org.eclipse.jetty.websocket.util.server.internal to org.eclipse.jetty.websocket.jetty.server, org.eclipse.jetty.websocket.javax.server; + + requires org.slf4j; + requires transitive org.eclipse.jetty.servlet; + requires transitive org.eclipse.jetty.websocket.core; +} diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketUpgradeFilter.java b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketUpgradeFilter.java similarity index 97% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketUpgradeFilter.java rename to jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketUpgradeFilter.java index d368da1846bb..b0a9c030e901 100644 --- a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketUpgradeFilter.java +++ b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketUpgradeFilter.java @@ -35,11 +35,11 @@ import org.eclipse.jetty.server.handler.ContextHandler; import org.eclipse.jetty.servlet.FilterHolder; import org.eclipse.jetty.servlet.ServletHandler; -import org.eclipse.jetty.util.annotation.ManagedAttribute; import org.eclipse.jetty.util.annotation.ManagedObject; import org.eclipse.jetty.util.component.Dumpable; import org.eclipse.jetty.websocket.core.Configuration; import org.eclipse.jetty.websocket.core.WebSocketComponents; +import org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -123,7 +123,7 @@ public static FilterHolder ensureFilter(ServletContext servletContext) return holder; } - public static final String MAPPING_ATTRIBUTE_INIT_PARAM = "org.eclipse.jetty.websocket.util.server.WebSocketMapping.key"; + public static final String MAPPING_ATTRIBUTE_INIT_PARAM = "org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping.key"; private final Configuration.ConfigurationCustomizer defaultCustomizer = new Configuration.ConfigurationCustomizer(); private WebSocketMapping mapping; @@ -159,12 +159,6 @@ public void dump(Appendable out, String indent) throws IOException Dumpable.dumpObjects(out, indent, this, mapping); } - @ManagedAttribute(value = "factory", readonly = true) - public WebSocketMapping getMapping() - { - return mapping; - } - @Override public void init(FilterConfig config) throws ServletException { diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/FrameHandlerFactory.java b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/FrameHandlerFactory.java similarity index 96% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/FrameHandlerFactory.java rename to jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/FrameHandlerFactory.java index d445156a99f8..bebcf7fe2039 100644 --- a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/FrameHandlerFactory.java +++ b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/FrameHandlerFactory.java @@ -16,7 +16,7 @@ // ======================================================================== // -package org.eclipse.jetty.websocket.util.server; +package org.eclipse.jetty.websocket.util.server.internal; import org.eclipse.jetty.websocket.core.FrameHandler; diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/ServletUpgradeRequest.java b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/ServletUpgradeRequest.java similarity index 98% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/ServletUpgradeRequest.java rename to jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/ServletUpgradeRequest.java index a4fbf382214d..152c67f37f09 100644 --- a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/ServletUpgradeRequest.java +++ b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/ServletUpgradeRequest.java @@ -16,7 +16,7 @@ // ======================================================================== // -package org.eclipse.jetty.websocket.util.server; +package org.eclipse.jetty.websocket.util.server.internal; import java.net.HttpCookie; import java.net.InetSocketAddress; @@ -41,7 +41,6 @@ import org.eclipse.jetty.websocket.core.ExtensionConfig; import org.eclipse.jetty.websocket.core.WebSocketConstants; import org.eclipse.jetty.websocket.core.server.Negotiation; -import org.eclipse.jetty.websocket.util.server.internal.UpgradeHttpServletRequest; /** * Holder of request data for a WebSocket upgrade request. diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/ServletUpgradeResponse.java b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/ServletUpgradeResponse.java similarity index 99% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/ServletUpgradeResponse.java rename to jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/ServletUpgradeResponse.java index 0b0642e1ab11..f78615f46c6d 100644 --- a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/ServletUpgradeResponse.java +++ b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/ServletUpgradeResponse.java @@ -16,7 +16,7 @@ // ======================================================================== // -package org.eclipse.jetty.websocket.util.server; +package org.eclipse.jetty.websocket.util.server.internal; import java.io.IOException; import java.util.ArrayList; diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/internal/UpgradeHttpServletRequest.java b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/UpgradeHttpServletRequest.java similarity index 100% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/internal/UpgradeHttpServletRequest.java rename to jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/UpgradeHttpServletRequest.java diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketCreator.java b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/WebSocketCreator.java similarity index 96% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketCreator.java rename to jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/WebSocketCreator.java index edfa3cd13b05..b991530193fc 100644 --- a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketCreator.java +++ b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/WebSocketCreator.java @@ -16,7 +16,7 @@ // ======================================================================== // -package org.eclipse.jetty.websocket.util.server; +package org.eclipse.jetty.websocket.util.server.internal; /** * Abstract WebSocket creator interface. diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketMapping.java b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/WebSocketMapping.java similarity index 97% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketMapping.java rename to jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/WebSocketMapping.java index d87305448695..a96a55d315c2 100644 --- a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/server/WebSocketMapping.java +++ b/jetty-websocket/websocket-util-server/src/main/java/org/eclipse/jetty/websocket/util/server/internal/WebSocketMapping.java @@ -16,7 +16,7 @@ // ======================================================================== // -package org.eclipse.jetty.websocket.util.server; +package org.eclipse.jetty.websocket.util.server.internal; import java.io.IOException; import java.util.concurrent.atomic.AtomicReference; @@ -45,8 +45,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static javax.servlet.http.HttpServletResponse.SC_SERVICE_UNAVAILABLE; - /** * Mapping of pathSpec to a tupple of {@link WebSocketCreator}, {@link FrameHandlerFactory} and * {@link Configuration.Customizer}. @@ -136,7 +134,7 @@ else if (rawSpec.startsWith("uri-template|")) throw new IllegalArgumentException("Unrecognized path spec syntax [" + rawSpec + "]"); } - public static final String DEFAULT_KEY = "org.eclipse.jetty.websocket.util.server.WebSocketMapping"; + public static final String DEFAULT_KEY = "org.eclipse.jetty.websocket.util.server.internal.WebSocketMapping"; private final PathMappings mappings = new PathMappings<>(); private final WebSocketComponents components; @@ -281,7 +279,7 @@ public FrameHandler negotiate(Negotiation negotiation) throws IOException if (websocketPojo == null) { // no creation, sorry - upgradeResponse.sendError(SC_SERVICE_UNAVAILABLE, "WebSocket Endpoint Creation Refused"); + upgradeResponse.sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE, "WebSocket Endpoint Creation Refused"); return null; } diff --git a/jetty-websocket/websocket-util/pom.xml b/jetty-websocket/websocket-util/pom.xml index 92cecbbb3bd6..bf962dad58fe 100644 --- a/jetty-websocket/websocket-util/pom.xml +++ b/jetty-websocket/websocket-util/pom.xml @@ -55,7 +55,6 @@ org.eclipse.jetty jetty-servlet ${project.version} - provided org.slf4j diff --git a/jetty-websocket/websocket-util/src/main/java/module-info.java b/jetty-websocket/websocket-util/src/main/java/module-info.java index 01ec7c0a1ddf..e569c7fc2110 100644 --- a/jetty-websocket/websocket-util/src/main/java/module-info.java +++ b/jetty-websocket/websocket-util/src/main/java/module-info.java @@ -20,7 +20,6 @@ { exports org.eclipse.jetty.websocket.util; exports org.eclipse.jetty.websocket.util.messages; - exports org.eclipse.jetty.websocket.util.server; requires org.slf4j; requires org.eclipse.jetty.servlet; diff --git a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/TextUtil.java b/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/TextUtils.java similarity index 99% rename from jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/TextUtil.java rename to jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/TextUtils.java index 21a2a138d1a6..20563f8af404 100644 --- a/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/TextUtil.java +++ b/jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/TextUtils.java @@ -21,7 +21,7 @@ /** * Collection of utility methods for Text content */ -public final class TextUtil +public final class TextUtils { /** * Create a hint of what the text is like. diff --git a/jetty-websocket/websocket-util/src/test/org/eclipse/jetty/websocket/util/PartialStringMessageSinkTest.java b/jetty-websocket/websocket-util/src/test/java/org/eclipse/jetty/websocket/util/PartialStringMessageSinkTest.java similarity index 97% rename from jetty-websocket/websocket-util/src/test/org/eclipse/jetty/websocket/util/PartialStringMessageSinkTest.java rename to jetty-websocket/websocket-util/src/test/java/org/eclipse/jetty/websocket/util/PartialStringMessageSinkTest.java index 1cb9e174fc8f..6569d8aed3b5 100644 --- a/jetty-websocket/websocket-util/src/test/org/eclipse/jetty/websocket/util/PartialStringMessageSinkTest.java +++ b/jetty-websocket/websocket-util/src/test/java/org/eclipse/jetty/websocket/util/PartialStringMessageSinkTest.java @@ -67,7 +67,7 @@ public void testValidUtf8() throws Exception List message = Objects.requireNonNull(endpoint.messages.poll(5, TimeUnit.SECONDS)); assertThat(message.size(), is(1)); - assertThat(message.get(0), is("\uD800\uDF48")); + assertThat(message.get(0), is("\uD800\uDF48")); // UTF-8 encoded payload. } @Test @@ -87,7 +87,7 @@ public void testUtf8Continuation() throws Exception List message = Objects.requireNonNull(endpoint.messages.poll(5, TimeUnit.SECONDS)); assertThat(message.size(), is(2)); assertThat(message.get(0), is("")); - assertThat(message.get(1), is("\uD800\uDF48")); + assertThat(message.get(1), is("\uD800\uDF48")); // UTF-8 encoded payload. } @Test diff --git a/jetty-websocket/websocket-util/src/test/org/eclipse/jetty/websocket/util/StringMessageSinkTest.java b/jetty-websocket/websocket-util/src/test/java/org/eclipse/jetty/websocket/util/StringMessageSinkTest.java similarity index 98% rename from jetty-websocket/websocket-util/src/test/org/eclipse/jetty/websocket/util/StringMessageSinkTest.java rename to jetty-websocket/websocket-util/src/test/java/org/eclipse/jetty/websocket/util/StringMessageSinkTest.java index f876c52a9420..79c50555bf54 100644 --- a/jetty-websocket/websocket-util/src/test/org/eclipse/jetty/websocket/util/StringMessageSinkTest.java +++ b/jetty-websocket/websocket-util/src/test/java/org/eclipse/jetty/websocket/util/StringMessageSinkTest.java @@ -72,7 +72,7 @@ public void testValidUtf8() throws Exception messageSink.accept(new Frame(OpCode.TEXT, utf8Payload).setFin(true), callback); callback.block(5, TimeUnit.SECONDS); - assertThat(endpoint.messages.poll(5, TimeUnit.SECONDS), is("\uD800\uDF48")); + assertThat(endpoint.messages.poll(5, TimeUnit.SECONDS), is("\uD800\uDF48")); // UTF-8 encoded payload. } @Test @@ -90,7 +90,7 @@ public void testUtf8Continuation() throws Exception messageSink.accept(new Frame(OpCode.TEXT, continuationUtf8Payload).setFin(true), callback); callback.block(5, TimeUnit.SECONDS); - assertThat(endpoint.messages.poll(5, TimeUnit.SECONDS), is("\uD800\uDF48")); + assertThat(endpoint.messages.poll(5, TimeUnit.SECONDS), is('\uD800' + '\uDF48')); // UTF-8 encoded payload. } @Test